Skip to content

[Forwardport] Fixed undefinded shipping method name issue #17492#53

Merged
gelanivishal merged 1203 commits into2.3-developfrom
2.3-develop-PR-port-17526
Aug 20, 2018
Merged

[Forwardport] Fixed undefinded shipping method name issue #17492#53
gelanivishal merged 1203 commits into2.3-developfrom
2.3-develop-PR-port-17526

Conversation

@gelanivishal
Copy link
Copy Markdown
Owner

Original Pull Request

magento#17526

Description

Fixed undefined error on shipping method name is not set.

Fixed Issues (if relevant)

  1. "- undefined" displayed in checkout summary when shipping method name is not set magento/magento2#17492: "- undefined" displayed in checkout summary when shipping method name is not set

Manual testing scenarios

  1. Add new or edit any existing shipping methods with Method name field left as a blank field.
  2. Add any product to the cart and go through the checkout to the last step.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Stanislav Idolov and others added 30 commits August 10, 2018 11:24
…agento#17446

 - Merge Pull Request magento#17446 from alexeya-ven/magento2:2.3-develop-PR-port-17437
 - Merged commits:
   1. 832bbae
   2. 55ec6a3
   3. 6a964ff
…uts magento#17350

 - Merge Pull Request magento#17350 from jignesh-baldha/magento2:2.3-develop-PR-port-16086
 - Merged commits:
   1. 494fa58
   2. 1124fb5
   3. 105b787
…en configurable products are generated with an attribute named "design"

- Update automated test
[tango] MAGETWO-91808: Categories of the Main menu in the different Store View not updated when varnish enabled
 - merged latest code from mainline branch
…tsFilter() together with getAllIds() for class Magento\Catalog\Model\ResourceModel\Product\Attribute\Collection

- Added integration test
serhii-balko and others added 29 commits August 16, 2018 17:13
Accepted Public Pull Requests:
 - magento/graphql-ce#127: Fixed return value for getGraphQlClient in API-functional tests (by @rogyar)
 - magento#17572: [Forwardport] Catalog: Add unit tests for Cron classes (by @jignesh-baldha)
 - magento#17573: [Forwardport] updating lib LESS docs (by @jignesh-baldha)
 - magento#17571: [Forwardport] Refactor: remove some code duplication (by @arnoudhgz)
 - magento#17562: Fix wrong return type in StockRegistryInterface API (by @vasilii-b)
 - magento#17502: [Forwardport] Doesn't work if use date as condition for Catalog Price Rules (by @mage2pratik)
 - magento#17551: [Forwardport] Fix possible undefined index when caching config data (by @mage2pratik)
 - magento#17554: [Forwardport] Fix magento#10687 - Product image roles disappearing (by @eduard13)
 - magento#16784: [Forwardport] Fix the issue with "Shipping address is not set" exception (by @dmytro-ch)
 - magento#17499: [Forwardport] Braintree: test coverage (by @ronak2ram)
 - magento#17610: [Forwardport] Link logo in web setup wizard to back-end base URL (by @arnoudhgz)
 - magento#17604: [Forwardport] Fix for magento#15041 Adding a new fieldset to the admin category editor changes the position of the 'General' fieldset (by @jignesh-baldha)
 - magento#17603: [Forwardport] Braintree: Add unit test for CreditCard/TokenFormatter (by @jignesh-baldha)
 - magento#17596: Typo in Magento\Cms\Model\Wysiwyg\Images\Storage function resizeFile() (by @eduard13)


Fixed GitHub Issues:
 - magento#15085: StockRegistryInterface :: getLowStockItems() returns StockStatusCollection instead of StockItemCollection (reported by @jesse-dev) has been fixed in magento#17562 by @vasilii-b in 2.3-develop branch
   Related commits:
     1. 897e7df

 - magento#10687: Product image roles randomly disappear (reported by @boxyman) has been fixed in magento#17554 by @eduard13 in 2.3-develop branch
   Related commits:
     1. 1c74f55

 - magento#16555: "Shipping address is not set" exception in Multishipping Checkout. (reported by @p-bystritsky) has been fixed in magento#16784 by @dmytro-ch in 2.3-develop branch
   Related commits:
     1. ab1324e
     2. 7187c2e
     3. 9868428
     4. 2c546c4

 - magento#13948: Sidebar shortcut to admin dashboard (Magento logo on top left) has no link in web setup wizard (reported by @doctormess) has been fixed in magento#17610 by @arnoudhgz in 2.3-develop branch
   Related commits:
     1. 43bbdb5

 - magento#15041: Adding a new fieldset to the admin category editor changes the position of the 'General' fieldset. (reported by @leoquijano) has been fixed in magento#17604 by @jignesh-baldha in 2.3-develop branch
   Related commits:
     1. b6df8e7

 - magento#17587: Typo in Magento\Cms\Model\Wysiwyg\Images\Storage function resizeFile($source, $keepRation = true) (reported by @simonworkhouse) has been fixed in magento#17596 by @eduard13 in 2.3-develop branch
   Related commits:
     1. 9a5bfd3
 - Merge Pull Request magento#17598 from thomas-blackbird/magento2:2.3-develop-PR-port-16021
 - Merged commits:
   1. e735178
   2. b00d4b2
   3. 7563605
 - Merge Pull Request magento/graphql-ce#138 from keharper/graphql-ce:issue-136
 - Merged commits:
   1. 3623e5c
 - merged latest code from mainline branch
[epam] MAGETWO-91620: It is not possible to use function setInAllAttributeSetsFilter() together with getAllIds() for class \Magento\Catalog\Model\ResourceModel\Product\Attribute\Collection
 - merged latest code from mainline branch
Accepted Public Pull Requests:
 - magento#17642: Change error message about low stock (by @vkublytskyi)
 - magento#17620: [Forwardport] Fix type error in Cart/Totals. (by @nmalevanec)
 - magento#17598: [Forwardport] Introduce Block Config Source (by @thomas-blackbird)
 - magento#17607: [Forwardport] 6305 - Resolved product custom option title save issue (by @jignesh-baldha)
 - magento#17232: Improve code quality subscriber new action (by @arnoudhgz)
 - magento#17574: [Forwardport] Solution for User role issue with customer group (by @jignesh-baldha)
 - magento/graphql-ce#138: Corrected field descriptions (by @keharper)


Fixed GitHub Issues:
 - magento#12819: CartTotalRepository cannot handle extension attributes in quote addresses in 2.2.2 (reported by @marius-bica) has been fixed in magento#17620 by @nmalevanec in 2.3-develop branch
   Related commits:
     1. 370dc84

 - magento#12993: Type error in Cart/Totals (reported by @andrewhowdencom) has been fixed in magento#17620 by @nmalevanec in 2.3-develop branch
   Related commits:
     1. 370dc84

 - magento#6305: Can't save Customizable options (reported by @bachlee89) has been fixed in magento#17607 by @jignesh-baldha in 2.3-develop branch
   Related commits:
     1. d60b3cf
     2. 71ce3fa
     3. 170d029
     4. 6aebfe8

 - magento#16499: User role issue with customer group (reported by @emiprotech) has been fixed in magento#17574 by @jignesh-baldha in 2.3-develop branch
   Related commits:
     1. 0d7dc6c
@gelanivishal gelanivishal merged commit bc1f271 into 2.3-develop Aug 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.