Skip to content

[Forwardport] Remove unnecessary translation of HTML tags#17431

Closed
yogeshsuhagiya wants to merge 0 commit intomagento:2.3-developfrom
yogeshsuhagiya:2.3-develop
Closed

[Forwardport] Remove unnecessary translation of HTML tags#17431
yogeshsuhagiya wants to merge 0 commit intomagento:2.3-developfrom
yogeshsuhagiya:2.3-develop

Conversation

@yogeshsuhagiya
Copy link
Copy Markdown
Member

Original Pull Request

#16354

Description

There is no need to translate string with HTML tags like <label> and <span>, instead translate only string value.

Fixed Issues (if relevant)

  1. N/A

Manual testing scenarios

  1. N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @yogeshks. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@yogeshsuhagiya yogeshsuhagiya changed the title 2.3 develop [Forwardport] Remove unnecessary translation of HTML tags Aug 8, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.0 milestone Aug 8, 2018
@orlangur orlangur self-assigned this Aug 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants