[Forwardport] MAGETWO-84608: Cannot perform setup:install if Redis needs a password…

[mage2pratik]

Original Pull Request

#17078

Description

Needed to perform setup on a fresh magento install using an authenticated redis instance for the cache configuration part.
Redis session password configuration works whereas the cache configuration does not take the provided configuration.
Changed setup/src/Magento/Setup/Model/ConfigOptionsList/Cache.php and setup/src/Magento/Setup/Model/ConfigOptionsList/PageCache.php to enable a configuration password during initial setup.

Fixed Issues (if relevant)

1. magento/magento2#MAGETWO-84608: Redis password not used when trying to validate the connection during install.

Manual testing scenarios

1. Setup a new magento instance with bin/magento setup:install with cache options in env.php as so :
   'cache' => [ 'frontend' => [ 'default' => [ 'backend' => 'Cm_Cache_Backend_Redis', 'backend_options' => [ 'server' => redis_host, 'database' => '0', 'port' => 6379, 'password' => redis_password ] ], 'page_cache' => [ 'backend' => 'Cm_Cache_Backend_Redis', 'backend_options' => [ 'server' => redis_host, 'port' => 6379, 'database' => '1', 'compress_data' => '0', 'password' => redis_password ] ] ] ],

The setup will fail saying that the redis configuration is wrong.

Contribution checklist

• [X ] Pull request has a meaningful description of its purpose
• [X ] All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-engcom-team]

Hi @mage2pratik. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on PR changes
• @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[magento-engcom-team]

Hi @sidolov, thank you for the review.
ENGCOM-2713 has been created to process this Pull Request

[magento-engcom-team]

Hi @mage2pratik. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.