[Forwardport] Fix #10687 - Product image roles disappearing#17554
Merged
magento-engcom-team merged 1 commit intomagento:2.3-developfrom Aug 16, 2018
Merged
[Forwardport] Fix #10687 - Product image roles disappearing#17554magento-engcom-team merged 1 commit intomagento:2.3-developfrom
magento-engcom-team merged 1 commit intomagento:2.3-developfrom
Conversation
Contributor
|
Hi @eduard13. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
VladimirZaets
approved these changes
Aug 12, 2018
Contributor
|
Hi @VladimirZaets, thank you for the review. |
Contributor
|
Hi @eduard13. Thank you for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original PR #15606
To fix #10687 - adds the 'types' key to the images array to provide existing image roles, which are reset after clearMediaAttribute() is called.
Description
This PR is to fix the issue outlined in #10687 - image roles being removed when saving by the ProductRepository.
Fixed Issues (if relevant)
Manual testing scenarios
Contribution checklist