Skip to content

Fix wrong return type in StockRegistryInterface API#17562

Merged
magento-engcom-team merged 1 commit intomagento:2.3-developfrom
vasilii-b:2.3-api-getLowStockItems-wrong-return-type
Aug 16, 2018
Merged

Fix wrong return type in StockRegistryInterface API#17562
magento-engcom-team merged 1 commit intomagento:2.3-developfrom
vasilii-b:2.3-api-getLowStockItems-wrong-return-type

Conversation

@vasilii-b
Copy link
Copy Markdown

Description

Full description in #15085.

Fixes wrong return type of StockRegistryInterface :: getLowStockItems() when using REST API /V1/stockItems/lowStock/

Fixed Issues (if relevant)

  1. StockRegistryInterface :: getLowStockItems() returns StockStatusCollection instead of StockItemCollection #15085

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@vasilii-b vasilii-b self-assigned this Aug 13, 2018
@vasilii-b vasilii-b requested a review from rogyar August 13, 2018 06:44
@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Component: CatalogInventory labels Aug 13, 2018
@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @vasilii-b. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @vasilii-b. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

@vasilii-b vasilii-b deleted the 2.3-api-getLowStockItems-wrong-return-type branch August 17, 2018 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Cleanup Component: CatalogInventory Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants