[Backport] Use correct error message for duplicate error key in product import#34
Merged
gelanivishal merged 330 commits into2.2-developfrom Jun 25, 2018
Merged
[Backport] Use correct error message for duplicate error key in product import#34gelanivishal merged 330 commits into2.2-developfrom
gelanivishal merged 330 commits into2.2-developfrom
Conversation
- MAGETWO-64467 [Indexer optimizations] Tables sharding / segmentation for price indexer
…asses, remove unused imports
- MAGETWO-64467 [Indexer optimizations] Tables sharding / segmentation for price indexer
…o2ce into MAGETWO-64467
- MAGETWO-64467: [Indexer optimizations] Tables sharding / segmentation for price indexer
…15521 - Merge Pull Request magento#15521 from diedburn/magento2:fix_breadcrumbs_encoding - Merged commits: 1. 213e11d 2. 603de52 3. e95f3f7
- MAGETWO-64467 [Indexer optimizations] Tables sharding / segmentation for price indexer
…ogin attempts cleanup magento#16306 - Merge Pull Request magento#16306 from rogyar/magento2:2.2-captcha-reset-frontend-it - Merged commits: 1. 690b39f 2. 1cb9476
… attempts cleanup magento#16300 - Merge Pull Request magento#16300 from rogyar/magento2:2.2-captcha-reset-admin-it - Merged commits: 1. 8982abe 2. c2832f3
[MAGETWO-92693] Some improvements on product create|edit page in admin area
- merged latest code from mainline branch
- Merge Pull Request magento#15845 from mhaack/magento2:patch-1 - Merged commits: 1. 55b476e
Accepted Public Pull Requests: - magento#16240: Removed double occurrence of 'it' from sentences. (by @namratachangani) - magento#16247: Fixed typo error (by @vgelani) - magento#16141: Fix case mismatch call (class/method) (by @lfluvisotto) - magento#15629: Fix magento#15627: Product order in category changed in Magento 2.2.4 (by @dverkade) - magento#16215: PHPDoc (by @lfluvisotto) - magento#15532: FIX for issue magento#15501 - M2.2.4 missing meta title tag and doesn't show� (by @phoenix128) - magento#15637: Create ability to set is_visible_on_front to order status history comment (by @markoshust) - magento#15521: Move breadcrumb json configuration to viewmodel (by @diedburn) Fixed GitHub Issues: - magento#15627: Product order in category changed after update to Magento 2.2.4 (reported by @dverkade) has been fixed in magento#15629 by @dverkade in 2.2-develop branch Related commits: 1. 8981225 - magento#15501: M2.2.4 missing meta title tag and doesn't show product name if meta title is empty (reported by @Naturegreen) has been fixed in magento#15532 by @phoenix128 in 2.2-develop branch Related commits: 1. 0a38b84 2. 85ac3be 3. 432cf00 4. 1413d65
[TSG] Backporting for 2.2 (pr31) (2.2.6)
Fixed issues: - DEVOPS-2632 Sample Data Builds Migrated from Bamboo
…ogin attempts cleanup magento#16306
…ning message appear two times magento#15774
Accepted Public Pull Requests: - magento#15845: Update webapi.xml to fix typo (by @mhaack) - magento#16306: Captcha: Added integration tests for checking customer login attempts cleanup (by @rogyar) - magento#16300: Captcha: Added integration test for checking admin login attempts cleanup (by @rogyar) - magento#16286: Add UpdatedAtListProvider to NotSyncedDataProvider for invoice grid (by @JeroenVanLeusden) - magento#15929: Postpone instantiation of session config by using a proxy (by @fmarangi) - magento#15872: Fix missing PHPDocs hinting for AdvancedPricingImportExport module (by @dmytro-ch) - magento#15774: [Backport] Fix issue magento#14895 - Change Password warning message appear two times (by @sanjay-wagento) - magento#12771: magento#12695: Unable to change attribute type from swatch (by @eugene-shab) Fixed GitHub Issues: - magento#15205: Upgraded to Magento 2.2.4 from Magento 2.1.9 - Locale and Store Configuration issues 'Store View' Locale not being used on frontend, 'Default Config' Locale being used instead (reported by @callumstar) has been fixed in magento#15929 by @fmarangi in 2.2-develop branch Related commits: 1. d23c198 2. b0b82d0 3. 7e835c3 - magento#15245: 2.2.4: Wrong home page loaded in multi store setup (reported by @jokeputs) has been fixed in magento#15929 by @fmarangi in 2.2-develop branch Related commits: 1. d23c198 2. b0b82d0 3. 7e835c3 - magento#14895: Change Password warning message appear two times (reported by @cnviradiya) has been fixed in magento#15774 by @sanjay-wagento in 2.2-develop branch Related commits: 1. b2cc966 2. cfe58e1 - magento#9307: Color attribute taking swatch instead of Drop down option for configurable options, (reported by @vishveskrish) has been fixed in magento#12771 by @eugene-shab in 2.2-develop branch Related commits: 1. 39b1ef3 2. 94539b7 3. 3d76096 4. 0b079e0 5. 71d30b7 6. 47b2f48 7. 707f1cd 8. 9153fe2 9. 1bd4acf 10. f499027 11. 3fa9ed2 12. 8fa792a 13. 7cd7ade 14. 54ad76c 15. bd12651 16. cb6975c - magento#9923: Upgrading to 2.1.7 changed dropdown attributes to swatches (reported by @roseofgold) has been fixed in magento#12771 by @eugene-shab in 2.2-develop branch Related commits: 1. 39b1ef3 2. 94539b7 3. 3d76096 4. 0b079e0 5. 71d30b7 6. 47b2f48 7. 707f1cd 8. 9153fe2 9. 1bd4acf 10. f499027 11. 3fa9ed2 12. 8fa792a 13. 7cd7ade 14. 54ad76c 15. bd12651 16. cb6975c - magento#11403: Product Attributes Not Updating on Frontend (reported by @rbur0425) has been fixed in magento#12771 by @eugene-shab in 2.2-develop branch Related commits: 1. 39b1ef3 2. 94539b7 3. 3d76096 4. 0b079e0 5. 71d30b7 6. 47b2f48 7. 707f1cd 8. 9153fe2 9. 1bd4acf 10. f499027 11. 3fa9ed2 12. 8fa792a 13. 7cd7ade 14. 54ad76c 15. bd12651 16. cb6975c - magento#11703: Changing Swatches to Drop-down does not remove swatches from existing products (reported by @expgabe) has been fixed in magento#12771 by @eugene-shab in 2.2-develop branch Related commits: 1. 39b1ef3 2. 94539b7 3. 3d76096 4. 0b079e0 5. 71d30b7 6. 47b2f48 7. 707f1cd 8. 9153fe2 9. 1bd4acf 10. f499027 11. 3fa9ed2 12. 8fa792a 13. 7cd7ade 14. 54ad76c 15. bd12651 16. cb6975c - magento#12695: Unable to change attribute type from swatch to dropdown (reported by @alena-marchenko) has been fixed in magento#12771 by @eugene-shab in 2.2-develop branch Related commits: 1. 39b1ef3 2. 94539b7 3. 3d76096 4. 0b079e0 5. 71d30b7 6. 47b2f48 7. 707f1cd 8. 9153fe2 9. 1bd4acf 10. f499027 11. 3fa9ed2 12. 8fa792a 13. 7cd7ade 14. 54ad76c 15. bd12651 16. cb6975c
MAGETWO-74021: "Catalog Products List" widget does not displays on frontend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original Pull Request
magento#15980
Description
During product CSV import, when a Url key duplicate is detected after the validation phase, the error message display only the error template but not the actual error details.
I have changed the
addRowError()call using the detailed error message.Fixed Issues (if relevant)
Manual testing scenarios
Contribution checklist