Fix case mismatch call (class/method)

[lfluvisotto]

Description

Fix case mismatch call (class/method), code quality.

[magento-engcom-team]

Hi @lfluvisotto. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento-engcom-team give me test instance - deploy test instance based on Pull Request changes
• @magento-engcom-team give me new test instance - deploy NEW test instance based on Pull Request changes
• @magento-engcom-team give me {$VERSION} instance - deploy Vanilla Magento instance for Issue or Pull Request

For more details, please, review the Magento Contributor Assistant documentation

[lfluvisotto]

@orlangur and @osrecio

Let me know when this PR gets merged then I will create the forwardport (2.3-develop) and backport (2.1-develop)

[orlangur]

@lfluvisotto bot is already doing this actually ;) PLEASE provide exact steps :)

[lfluvisotto]

Hi @orlangur

I didn't get that "provide exact steps".

What am I supposed to do?

[orlangur]

@lfluvisotto exact steps which you used to obtain this places to fix.

[lfluvisotto]

@orlangur

I sad that in other PR's comment I think you have noticed that.

I use ide phpstorm + code sniffer + mess detector + tools in https://phpqa.io/ + regular expressions

I iterate in every/each php file (in app and lib folders) those tools.

And this ruleset dev/tests/static/framework/Magento/ruleset.xml

[orlangur]

@lfluvisotto I need specific steps for this specific PR which I can actually reproduce. Just throw a list of used tools is not enough :)

Then I can see which of the tools could be integrated into CICD loop to enforce such issues won't appear again.

[lfluvisotto]

Also I use this plugin in phpstorm.

https://github.com/kalessil/phpinspectionsea

Customize the travis.yml to be executed/used in the CICD

[orlangur]

@lfluvisotto which of the tools specifically was used to spot all the

case mismatch call (class/method)

inspection violations?

[lfluvisotto]

https://github.com/kalessil/phpinspectionsea/blob/master/RULES.md

Inspections Lists (Code style) > CallableReferenceNameMismatchInspection > Callable name case mismatched in a call

[lfluvisotto]

I will have a look tonight how to call phpinspectionsea in Travis CI

[magento-engcom-team]

Hi @sidolov, thank you for the review.
ENGCOM-2045 has been created to process this Pull Request

[magento-engcom-team]

Hi @lfluvisotto. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.6 release.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.