Fix #15627: Product order in category changed in Magento 2.2.4

[dverkade]

Description

This PR is a fix for issue #15627 where the default sorting behaviour of Magento was changed in Magento 2.2.4.

Fixed Issues

1. Product order in category changed after update to Magento 2.2.4 #15627: Product order in category changed after update to Magento 2.2.4

Manual testing scenarios

1. Have a category in Magento with several products in it, all have the position in the category set to the value 0
2. The default sort order should be set to position
3. View the category. The product with the highest entity_id (newest product) should be shown first.

[magento-cicd2]

All committers have signed the CLA.

[ishakhsuvarov]

Hi @dverkade
Do you think this fix would not cause #11139 to reproduce again?

[dverkade]

Hi @ishakhsuvarov,

Thank you for your reply. This PR will not change the fixes introduced by #11139 which will still be there. This PR removes an unnecessary extra sort order introduced by #11139. I have also filed a bug report for this behaviour under #15626 as you can see the sort order for entity_id is added multiple times now and this changed the default sorting behaviour of Magento. The default sorting of entity_id descending is already always added by Magento, so no need to specify it again with the fixes introduced for #11139.

[ishakhsuvarov]

@dverkade Seems legit to me. Thank you for the detailed explanation.

[magento-engcom-team]

Hi @dverkade. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.6 release.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.