Skip to content

[Backport] Fix issue #14895 - Change Password warning message appear two times#15774

Merged
magento-engcom-team merged 2 commits intomagento:2.2-developfrom
sanjay-wagento:2.2-develop-PR-port-14897
Jun 24, 2018
Merged

[Backport] Fix issue #14895 - Change Password warning message appear two times#15774
magento-engcom-team merged 2 commits intomagento:2.2-developfrom
sanjay-wagento:2.2-develop-PR-port-14897

Conversation

@sanjay-wagento
Copy link
Copy Markdown
Contributor

Original Pull Request

#14897
The password change notice was a sticky message activated by admin_user_authenticate_after event.
The password change page requires the current user password and thus triggering admin_user_authenticate_after while saving.
One message was added every time the user was saved.

Fixed Issues (if relevant)

  1. Change Password warning message appear two times #14895: Change Password warning message appear two times

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

…he password change notice was a sticky message activated by admin_user_authenticate_after event. The password change page requires the current user password and thus triggering admin_user_authenticate_after while saving. One message was added every time the user was saved.
…r/Backend/AuthObserverTest.php is checking for a single getMessages() call
@magento-engcom-team
Copy link
Copy Markdown
Contributor

Hi @sanjay-wagento. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.6 release.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: User Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants