Skip to content

Move breadcrumb json configuration to viewmodel#15521

Merged
magento-engcom-team merged 3 commits intomagento:2.2-developfrom
diedburn:fix_breadcrumbs_encoding
Jun 22, 2018
Merged

Move breadcrumb json configuration to viewmodel#15521
magento-engcom-team merged 3 commits intomagento:2.2-developfrom
diedburn:fix_breadcrumbs_encoding

Conversation

@diedburn
Copy link
Copy Markdown
Contributor

@diedburn diedburn commented May 25, 2018 •
edited by tdgroot
Loading

Description

Move breadcrumb json configuration to viewmodel and serialize it using Magento json serializer
Tweak code motivated by discussion in pull request #15162

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Copy Markdown
Contributor

magento-cicd2 commented May 25, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@diedburn
Copy link
Copy Markdown
Contributor Author

diedburn commented May 25, 2018

I signed the license agreement.

@dmanners dmanners self-assigned this May 29, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.5 milestone May 29, 2018
@magento-engcom-team
Copy link
Copy Markdown
Contributor

magento-engcom-team commented May 29, 2018

@diedburn thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

VladimirZaets
VladimirZaets reviewed May 31, 2018
View reviewed changes
Comment thread app/code/Magento/Catalog/ViewModel/Product/Breadcrumbs.php Outdated

$this->catalogData = $catalogData;
$this->scopeConfig = $scopeConfig;
$this->json = $json;
Copy link
Copy Markdown
Contributor

@VladimirZaets VladimirZaets May 31, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @diedburn, due to Magento backward-compatible guide we can't add the required dependency to the constructor method.
thanks

@VladimirZaets VladimirZaets self-assigned this May 31, 2018
@VladimirZaets
Copy link
Copy Markdown
Contributor

VladimirZaets commented May 31, 2018

Hi @vgelani, please, sign CLA, otherwise, we can't process your pull request

@gelanivishal
Copy link
Copy Markdown
Contributor

gelanivishal commented Jun 2, 2018

@VladimirZaets I have signed.

@dmanners
Copy link
Copy Markdown
Contributor

dmanners commented Jun 5, 2018

Hi @diedburn it still says that you have not signed the CLA, could you please check this for us so we can continue with this PR. Often this can happen if the github user and committed user have a different email address.

@diedburn
Copy link
Copy Markdown
Contributor Author

diedburn commented Jun 7, 2018 •
edited
Loading

@dmanners
I got it working by changing my primary email, then signing the CLA.

@VladimirZaets
Copy link
Copy Markdown
Contributor

VladimirZaets commented Jun 19, 2018

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Copy Markdown
Contributor

magento-engcom-team commented Jun 19, 2018

Hi @VladimirZaets. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Copy Markdown
Contributor

magento-engcom-team commented Jun 19, 2018

Hi @VladimirZaets, here is your Magento instance.
Admin access: https://pr-15521.engcom.dev.magento.com/admin
Login: admin Password: 123123q
Please make sure you are PR author or assignee to access the instance.

@magento-engcom-team magento-engcom-team merged commit e95f3f7 into magento:2.2-develop Jun 22, 2018
magento-engcom-team pushed a commit that referenced this pull request Jun 22, 2018
@VladimirZaets
ENGCOM-1703: Move breadcrumb json configuration to viewmodel #15521
847caf1
@magento-engcom-team
Copy link
Copy Markdown
Contributor

magento-engcom-team commented Jun 22, 2018

Hi @diedburn. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.6 release.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

This was referenced Jun 30, 2018
Merged
Merged
This was referenced Sep 7, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@VladimirZaets VladimirZaets VladimirZaets left review comments

Assignees

@dmanners dmanners

@VladimirZaets VladimirZaets

Labels

Area: Frontend Component: Catalog Progress: accept Release Line: 2.2

Projects

None yet

Milestone

Release: 2.2.6

Development

Successfully merging this pull request may close these issues.

7 participants

@diedburn @magento-cicd2 @magento-engcom-team @VladimirZaets @gelanivishal @dmanners @tdgroot