[Forwardport] Fixed Purchased Order Form button should visible properly#3
Merged
gelanivishal merged 127 commits into2.3-developfrom May 23, 2018
Merged
[Forwardport] Fixed Purchased Order Form button should visible properly#3gelanivishal merged 127 commits into2.3-developfrom
gelanivishal merged 127 commits into2.3-developfrom
Conversation
- Merge Pull Request magento#14395 from Igloczek/magento2:extends-fix - Merged commits: 1. f5e429d
DTO setter methods are no more required, parameters can be handled through constructor for immutable state approach A setter fallback is supported
_createFromArray will not be fixed due to its eventual deprecation, since a new immutable approach is provided
…m:phoenix128/magento2 into webapi-support-immutable-construct-params
…negative price is displayed as +- 5.00 for instance. By changing the template to check of the value is actually positive a negative value will be displayed as - 5.00 and a positive value will be displayed as + 5.00
Add missing commits for \app\code\Magento\Sales\Model\Order\Email\Sender\OrderSender.php
… altered in email_invoice_set_template_vars_before Event magento#15039 - Merge Pull Request magento#15039 from gwharton/magento2:2.3-develop-10210 - Merged commits: 1. 6dff3a5
- Merge Pull Request magento#11368 from slackerzz/magento2:fix_issue_2956 - Merged commits: 1. 32e2e4d 2. b11c7e7 3. 474e43c
…oduct from /checkout/cart page after already been removed from mini-shopping cart
- Fixed setting propagation - Added regression unit tests
- Fixed static error
- Updated test names
…agento#14975 - Merge Pull Request magento#14975 from dverkade/magento2:2.3-Fix-negative-value-for-custom-option - Merged commits: 1. 3a12905
…oduct from /checkout/cart page after already been removed from mini-shopping cart - added test for the failed workflow
…oduct from /checkout/cart page after already been removed from mini-shopping cart - updated annotation
- Fixed URL for creating StoreView
[EngCom] Public Pull Requests - 2.3-develop
…2_2.3-upgrade-changes
…pgrade-changes [borg] MAGETWO-87492: Changing S2 CLI upgrade jobs to include additional 2.3 steps
- merged latest code from mainline branch
[Team 3] Sprint 8 Delivery - bugfixes
- merged latest code from mainline branch
Accepted Public Pull Requests: - magento#15370: Fixed typo in MagentoUi abstract.js (by @VitaliyBoyko) - magento#15257: Fixes in InstantPurchase (by @mhauri)
gelanivishal
pushed a commit
that referenced
this pull request
Jun 7, 2018
- Merge Pull Request magento#15797 from chirag-wagento/magento2:2.1-develop-PR-port-15789 - Merged commits: 1. 8bacebe
gelanivishal
pushed a commit
that referenced
this pull request
Jun 7, 2018
gelanivishal
pushed a commit
that referenced
this pull request
Jun 7, 2018
Accepted Public Pull Requests: - magento#15767: [Backport] FIX fo rissue magento#15510 - First PDF download / export after login (by @sanjay-wagento) - magento#15797: [Backport] Removed unnecessary css. #3 (by @chirag-wagento) - magento#15796: [Backport] [Resolved : Styling <select> by changing less variables in Luma theme� (by @hitesh-wagento) - magento#15801: [Backport] Prevent multiple add-to-cart initializations in case of ajax loaded product listing (by @viral-wagento) - magento#15855: [Backport 2.1] Fixed return type hinting in DocBlocks for Wishlist module (by @rogyar) - magento#15841: [Backport] Fix for issue 911 found on MSI project - Cannot read property source_� #15 (by @chirag-wagento) - magento#15776: [Backport] Added additional headers for avoiding customer data caching (by @rogyar) Fixed GitHub Issues: - magento#15510: First PDF download / export after login (reported by @anthony-jullien) has been fixed in magento#15767 by @sanjay-wagento in 2.1-develop branch Related commits: 1. 8e43c07 - magento#15608: Styling <select> by changing less variables in Luma theme doesn't work as expected (reported by @denistrator) has been fixed in magento#15796 by @hitesh-wagento in 2.1-develop branch Related commits: 1. d3184ac
gelanivishal
pushed a commit
that referenced
this pull request
Jun 30, 2018
[Forwardport] Fixed set template syntax issue
gelanivishal
pushed a commit
that referenced
this pull request
Jul 13, 2018
[Backport] magento#16079 translation possibility for moreButtonText
gelanivishal
pushed a commit
that referenced
this pull request
Aug 11, 2018
[Forwardport] Remove unnecessary translation of HTML tags
gelanivishal
pushed a commit
that referenced
this pull request
Nov 22, 2018
Backport [PR 18772] Remove unnecesary "header" block redeclaration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original Pull Request
magento#15372
Fixed purchase order button issue.
Description
I have fixed place order button issue on selecting purchase order payment method. Please check here
https://www.screencast.com/t/852NjaQC
Fixed Issues (if relevant)
N/A
Manual testing scenarios
Contribution checklist