Fix meta title property

[slackerzz]

Description

If, inside a controller you try to set metadata title with:

$resultPage->getConfig()->setMetadata('title', 'some meta title');

you will get an error on frontend:

Recoverable Error: Object of class Magento\Framework\View\Page\Title could not be converted to string...

becouse processMetadataContent will return an istance of Magento\Framework\View\Page\Title instead of a string.

Fixed Issues (if relevant)

1. Unable to render page when 'meta title' page config param is set #2956: Unable to render page when 'meta title' page config param is set

Manual testing scenarios

Scenario 1

1. Create a controller
2. Inside the execute function add:

$resultPage = $this->resultPageFactory->create();
$resultPage->getConfig()->getTitle->set('my title');
$resultPage->getConfig()->setMetadata('title', 'metatitle');
return $resultPage;

3. As result you will have in your page:

<title>my title</title>
<meta name="title" content="metatitle"/>

Scenario 2

1. Create a controller
2. Inside the execute function add:

$resultPage = $this->resultPageFactory->create();
$resultPage->getConfig()->getTitle->set('my title');
return $resultPage;

3. As result you will have in your page:

<title>my title</title>
<meta name="title" content="my title"/>

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[orlangur]

Why do we need escapeHtml here? Seems inconsistent with other meta data getters.

Maybe just add __toString to \Magento\Framework\View\Page\Title?

[slackerzz]

Becouse in the same file at line 109 we have:

return '<title>' . $this->escaper->escapeHtml($this->pageConfig->getTitle()->get()) . '</title>' . "\n";

so i reproduced the same behaviour

[slackerzz]

I think the original reason for that is that if someone enter some html inside the title is has to be escaped to not break the html

[slackerzz]

tests are failing, i'll try to fix them

[slackerzz]

@magento-engcom-team any news?

[orlangur]

Hi @slackerzz, changes looks good to me now but process has changed a bit since the time this PR was created.

We need to deliver any contribution into 2.2-develop first, could you please create a new PR targeting 2.2-develop leaving this one as is or change a target branch of this PR?

[slackerzz]

Hi @orlangur, i'll create a new PR since changing the target branch generates a lot of conflicts

[magento-engcom-team]

Hi @slackerzz. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.3.0 release.