Skip to content

[Forwardport] set correct annotation#15

Merged
gelanivishal merged 1 commit into2.3-developfrom
2.3-develop-PR-port-15602
Jun 1, 2018
Merged

[Forwardport] set correct annotation#15
gelanivishal merged 1 commit into2.3-developfrom
2.3-develop-PR-port-15602

Conversation

@gelanivishal
Copy link
Copy Markdown
Owner

Original Pull Request

magento#15602

Description

Set correct annotation to formatDateTime function in lib/internal/Magento/Framework/Stdlib/DateTime/TimezoneInterface.php file

Fixed Issues (if relevant)

  1. magento/magento2#<15601>: Wrong annotation in formatDateTime - lib/internal/Magento/Framework/Stdlib/DateTime/TimezoneInterface.php

Manual testing scenarios

  1. Please review lib/internal/Magento/Framework/Stdlib/DateTime/TimezoneInterface.php
  2. Please review lib/internal/Magento/Framework/Stdlib/DateTime/Timezone.php

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@gelanivishal gelanivishal merged commit 6ff15f6 into 2.3-develop Jun 1, 2018
gelanivishal pushed a commit that referenced this pull request Jun 7, 2018
…ot read property source_… #15 magento#15841

 - Merge Pull Request magento#15841 from chirag-wagento/magento2:2.1-develop-PR-port-14805
 - Merged commits:
   1. 68e19af
gelanivishal pushed a commit that referenced this pull request Jun 7, 2018
gelanivishal pushed a commit that referenced this pull request Jun 7, 2018
Accepted Public Pull Requests:
 - magento#15767: [Backport] FIX fo rissue magento#15510 - First PDF download / export after login (by @sanjay-wagento)
 - magento#15797: [Backport] Removed unnecessary css. #3 (by @chirag-wagento)
 - magento#15796: [Backport] [Resolved : Styling <select> by changing less variables in Luma theme� (by @hitesh-wagento)
 - magento#15801: [Backport] Prevent multiple add-to-cart initializations in case of ajax loaded product listing (by @viral-wagento)
 - magento#15855: [Backport 2.1] Fixed return type hinting in DocBlocks for Wishlist module (by @rogyar)
 - magento#15841: [Backport] Fix for issue 911 found on MSI project - Cannot read property source_� #15 (by @chirag-wagento)
 - magento#15776: [Backport] Added additional headers for avoiding customer data caching (by @rogyar)


Fixed GitHub Issues:
 - magento#15510: First PDF download / export after login (reported by @anthony-jullien) has been fixed in magento#15767 by @sanjay-wagento in 2.1-develop branch
   Related commits:
     1. 8e43c07

 - magento#15608: Styling <select> by changing less variables in Luma theme doesn't work as expected (reported by @denistrator) has been fixed in magento#15796 by @hitesh-wagento in 2.1-develop branch
   Related commits:
     1. d3184ac
gelanivishal pushed a commit that referenced this pull request Oct 10, 2018
… adding mergi… #15

 - Merge Pull Request magento-commerce/async-import#15 from comwrap/async-import:support-HTTP_DELETE-for-bulk
 - Merged commits:
   1. 9ec6db2
gelanivishal pushed a commit that referenced this pull request Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants