Fix Newsletter's TransportBuilderTest#2579
Closed
mmenozzi wants to merge 1 commit intomagento:developfrom
mmenozzi:patch-1
Closed
Fix Newsletter's TransportBuilderTest#2579mmenozzi wants to merge 1 commit intomagento:developfrom mmenozzi:patch-1
mmenozzi wants to merge 1 commit intomagento:developfrom
mmenozzi:patch-1
Conversation
Method declaration `\Magento\Newsletter\Test\Unit\Model\Queue\TransportBuilderTest::testGetTransport()` is now compatible with its parent `\Magento\Framework\Mail\Test\Unit\Template\TransportBuilderTest::testGetTransport()`.
Member
|
@mmenozzi Thanks for your contribution. Would you please accept the license/CLA? |
Contributor
Author
|
Hi @davidalger, ok now it's signed. |
Contributor
Author
|
I also think that this PR could fix the same error stated in #2365 |
|
@mmenozzi Thank you for your contribution but this PR could not be processed as initial issue already resalved in another commit |
Contributor
Author
|
Yes it's true but my PR was 20 days before that commit ;). |
magento-engcom-team
pushed a commit
that referenced
this pull request
May 22, 2018
[EngCom] Public Pull Requests - 2.3-develop
deiserh
added a commit
to deiserh/magento2
that referenced
this pull request
Sep 22, 2019
… country change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Method declaration
\Magento\Newsletter\Test\Unit\Model\Queue\TransportBuilderTest::testGetTransport()is now compatible with its parent\Magento\Framework\Mail\Test\Unit\Template\TransportBuilderTest::testGetTransport().