Fixed typo in MagentoUi abstract.js#15370
Merged
magento-engcom-team merged 2 commits intomagento:2.3-developfrom May 23, 2018
Merged
Fixed typo in MagentoUi abstract.js#15370magento-engcom-team merged 2 commits intomagento:2.3-developfrom
magento-engcom-team merged 2 commits intomagento:2.3-developfrom
Conversation
VitaliyBoyko
added
typo
partners-contribution
- used singular possessive
okorshenko
approved these changes
May 21, 2018
Contributor
|
Hi @okorshenko, thank you for the review. |
This was referenced May 21, 2018
magento-engcom-team
pushed a commit
that referenced
this pull request
May 23, 2018
Contributor
|
Hi @VitaliyBoyko. Thank you for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Typo in abstract.js
propertie'sshould bepropertiesDescription
MagentoUI abstract.js:223 typo in doc block
* Sets 'value' as 'hidden' propertie's value, triggers 'toggle' event,