-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Added the current company in Repost from SLE Document which was otherwise picking the session default even in multi-company setup #45085
Open
basant-in
wants to merge
25
commits into
frappe:version-15-hotfix
Choose a base branch
from
basant-in:version-15-basant-bugfixes
base: version-15-hotfix
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: release v15
## [15.45.5](frappe/erpnext@v15.45.4...v15.45.5) (2024-12-12) ### Bug Fixes * 'Use Multi-Level BOM' checkbox default value (backport [frappe#44618](frappe#44618)) ([frappe#44620](frappe#44620)) ([5cd3994](frappe@5cd3994)) * add docstatus for translation ([47e1ed1](frappe@47e1ed1)) * add label strings for translation in pos_controller.js ([ffdd7cf](frappe@ffdd7cf)) * add labels for translation in production_analytics.py ([7a6cb0f](frappe@7a6cb0f)) * add labels for translation in purchase_order_analysis.py ([f06827c](frappe@f06827c)) * add labels for translation in quality_inspection_summary.py ([dd3a747](frappe@dd3a747)) * add labels for translation in sales_order_analysis.py ([6980d1e](frappe@6980d1e)) * add labels for translation in sales_order.js ([283043e](frappe@283043e)) * add string for translation in delayed_tasks_summary.py ([43fc8bf](frappe@43fc8bf)) * add strings for translation in pos_item_cart.js ([71d8dfb](frappe@71d8dfb)) * add strings for translation in timesheet.js ([frappe#44496](frappe#44496)) ([106671a](frappe@106671a)) * add strings for translation payment_terms_status_for_sales_order.py ([773e03f](frappe@773e03f)) * add title for translation in asset.js ([843ff18](frappe@843ff18)) * **Bank Transaction:** error in party matching should not block submitting (backport [frappe#44416](frappe#44416)) ([frappe#44574](frappe#44574)) ([31c2b81](frappe@31c2b81)) * BOM for variant items (backport [frappe#44580](frappe#44580)) ([frappe#44584](frappe#44584)) ([0b26827](frappe@0b26827)) * BOM has not attr required items (backport [frappe#44598](frappe#44598)) ([frappe#44600](frappe#44600)) ([608eaaa](frappe@608eaaa)) * BOM name issue (backport [frappe#44575](frappe#44575)) ([frappe#44579](frappe#44579)) ([03ae9e2](frappe@03ae9e2)) * BOM name issue (backport [frappe#44586](frappe#44586)) ([frappe#44589](frappe#44589)) ([a5cc307](frappe@a5cc307)) * consider zero valuation rate for serial nos (backport [frappe#44532](frappe#44532)) ([frappe#44534](frappe#44534)) ([3771c6e](frappe@3771c6e)) * correct color for draft in list view ([cce1cc6](frappe@cce1cc6)) * currency symbol in SCO and SCR (backport [frappe#44577](frappe#44577)) ([frappe#44594](frappe#44594)) ([2a17ecd](frappe@2a17ecd)) * description overwrite on qty change (backport [frappe#44606](frappe#44606)) ([frappe#44609](frappe#44609)) ([243bf54](frappe@243bf54)) * do not allow to inward same serial nos multiple times (backport [frappe#44617](frappe#44617)) ([frappe#44619](frappe#44619)) ([bdb60a5](frappe@bdb60a5)) * duplicate required items in the CSV (backport [frappe#44498](frappe#44498)) ([frappe#44507](frappe#44507)) ([539c5b7](frappe@539c5b7)) * incorrect stock UOM for BOM raw materials (backport [frappe#44528](frappe#44528)) ([frappe#44531](frappe#44531)) ([f4aa4c9](frappe@f4aa4c9)) * inv dimensions fields not creating for standard doctype (backport [frappe#44504](frappe#44504)) ([frappe#44515](frappe#44515)) ([8733eda](frappe@8733eda)) * make projected qty editable after submit (backport [frappe#44670](frappe#44670)) ([frappe#44671](frappe#44671)) ([bd9c84d](frappe@bd9c84d)) * not able to make PO for returned qty from material request (backport [frappe#44540](frappe#44540)) ([frappe#44547](frappe#44547)) ([5ef063c](frappe@5ef063c)) * not able to make sales return entry (backport [frappe#44605](frappe#44605)) ([frappe#44613](frappe#44613)) ([04b07a9](frappe@04b07a9)) * precision check for salvage value ([ef5a564](frappe@ef5a564)) * prevent set_payment_schedule on return documents ([2560beb](frappe@2560beb)) * required by date in the reorder material request (backport [frappe#44497](frappe#44497)) ([frappe#44509](frappe#44509)) ([07df87a](frappe@07df87a)) * restrict advance payment entries with flag ([98bd5f2](frappe@98bd5f2)) * strings for translation in pos_past_order_summary.js ([ceec5fd](frappe@ceec5fd)) * update free item qty while adding same item in seperate row ([f88dc26](frappe@f88dc26)) * update qty in SABB if qty changed in stock reco (backport [frappe#44542](frappe#44542)) ([frappe#44546](frappe#44546)) ([99a3271](frappe@99a3271)) * validate returned serial nos and batches (backport [frappe#44669](frappe#44669)) ([frappe#44674](frappe#44674)) ([33273fa](frappe@33273fa)) * valuation rate for batch in stock reconciliation (backport [frappe#44657](frappe#44657)) ([frappe#44664](frappe#44664)) ([2466e4c](frappe@2466e4c)) * variant qty while making work order from BOM (backport [frappe#44548](frappe#44548)) ([frappe#44551](frappe#44551)) ([63b1df3](frappe@63b1df3))
chore: release v15
# [15.46.0](frappe/erpnext@v15.45.5...v15.46.0) (2024-12-18) ### Bug Fixes * add doc.status to translation from POS ([0ba6e60](frappe@0ba6e60)) * allow all dispatch address for drop ship invoice ([db3a87c](frappe@db3a87c)) * broken CI ([78d7d71](frappe@78d7d71)) * delink SABB from cancelled SLEs (backport [frappe#44691](frappe#44691)) ([frappe#44719](frappe#44719)) ([8940747](frappe@8940747)) * duplicate Use Multi-Level BOM checkbox ([frappe#44757](frappe#44757)) ([3ac801c](frappe@3ac801c)) * handle zero salvage value case ([632a45d](frappe@632a45d)) * make rate of depreciation mandatory ([ed42ed0](frappe@ed42ed0)) * pos invoice return reference missing (backport [frappe#44720](frappe#44720)) ([frappe#44729](frappe#44729)) ([8aec131](frappe@8aec131)) * purchase return entry issue (backport [frappe#44721](frappe#44721)) ([frappe#44737](frappe#44737)) ([8ba7424](frappe@8ba7424)) * remove invalid filter in Account Receivable report ([fdfbb57](frappe@fdfbb57)) * set company bank account if default account not set in mode of payment ([a8f7393](frappe@a8f7393)) * switched asset terminology from cost to value ([47c7356](frappe@47c7356)) * unsupported operand type (backport [frappe#44722](frappe#44722)) ([frappe#44723](frappe#44723)) ([158a480](frappe@158a480)) * update cc_to multiselect in process statement of accounts ([df9bc33](frappe@df9bc33)) * update discount when pricing rule is changed ([f1a5000](frappe@f1a5000)) * User permissions in financial statements ([83aeb2e](frappe@83aeb2e)) * using query.walk() for escaping ([40a8ed8](frappe@40a8ed8)) * Wrong allocated_amount for sales_team in gross_profit report ([frappe#42989](frappe#42989)) ([328b9e7](frappe@328b9e7)) ### Features * change type link to multiselect ([7665eac](frappe@7665eac))
(cherry picked from commit 9a43acb)
…44765 fix: 'str' object has no attribute 'get_sql' (backport frappe#44765)
## [15.46.1](frappe/erpnext@v15.46.0...v15.46.1) (2024-12-18) ### Bug Fixes * 'str' object has no attribute 'get_sql' ([8eb8cc5](frappe@8eb8cc5))
(cherry picked from commit ed231ab)
(cherry picked from commit 919abd2)
…44825 fix: Ledger repost support for extending app doctypes (backport frappe#44825)
## [15.46.2](frappe/erpnext@v15.46.1...v15.46.2) (2024-12-23) ### Bug Fixes * Add hooks for repost allowed doctypes ([640c13a](frappe@640c13a)) * Ledger repost support for extending app doctypes ([a79d294](frappe@a79d294))
chore: release v15
# [15.47.0](frappe/erpnext@v15.46.2...v15.47.0) (2024-12-25) ### Bug Fixes * 'str' object has no attribute 'get_sql' ([8b810f5](frappe@8b810f5)) * add `Stock UOM` when adding new item in POS list ([frappe#44780](frappe#44780)) ([96cc9e2](frappe@96cc9e2)) * Add hooks for repost allowed doctypes ([b5596d9](frappe@b5596d9)) * added docs.frappe.io in documentation_url ([frappe#44776](frappe#44776)) ([0fd7792](frappe@0fd7792)) * asset field precision check ([516a325](frappe@516a325)) * avg. buying amount for product bundle item with serial and batch no in gross profit report ([2edb6f3](frappe@2edb6f3)) * better indicator base amount for Tax Witholding in Journal Entry ([218e777](frappe@218e777)) * buying rate for service item in gross profit report ([a55aaea](frappe@a55aaea)) * closing stock balance permissions (backport [frappe#44791](frappe#44791)) ([frappe#44793](frappe#44793)) ([cdeec8d](frappe@cdeec8d)) * correct args for get_advance_payment_entries_for_regional ([875797e](frappe@875797e)) * correct tds rate with lower deduction certificate ([5ca60f3](frappe@5ca60f3)) * do not set cost_center update_voucher_balance as it is set in init_voucher_balance ([19a8ea2](frappe@19a8ea2)) * do not validate qc for scrap item (backport [frappe#44844](frappe#44844)) ([frappe#44853](frappe#44853)) ([8092d58](frappe@8092d58)) * Duplicate entry ' EF1DE8B2E1B6' for key 'PRIMARY' (backport [frappe#44809](frappe#44809)) ([frappe#44814](frappe#44814)) ([16b013f](frappe@16b013f)) * fetch tax withholding category from the voucher ([8f8dd1c](frappe@8f8dd1c)) * incoming rate should be zero for rejected items (backport [frappe#44857](frappe#44857)) ([frappe#44859](frappe#44859)) ([0969877](frappe@0969877)) * incorrect Material Transferred for Manufacturing qty (backport [frappe#44823](frappe#44823)) ([frappe#44832](frappe#44832)) ([497029f](frappe@497029f)) * Ledger repost support for extending app doctypes ([d137f78](frappe@d137f78)) * Paid + Write Off Amount issue in Sales Invoice (backport [frappe#44763](frappe#44763)) ([frappe#44874](frappe#44874)) ([ca7c229](frappe@ca7c229)) * permissions for marking Quotation as lost ([e6390bf](frappe@e6390bf)) * POS Closing entry issue (backport [frappe#44772](frappe#44772)) ([frappe#44781](frappe#44781)) ([2032422](frappe@2032422)) * posting_time issue ([frappe#44870](frappe#44870)) ([7a5c30f](frappe@7a5c30f)) * Remove typo ([13a3c81](frappe@13a3c81)) * set project in GL from the SLE (backport [frappe#44879](frappe#44879)) ([frappe#44885](frappe#44885)) ([57e6ed4](frappe@57e6ed4)) * show profit and loss after period closing ([771632a](frappe@771632a)) * slow posting datetime update (backport [frappe#44799](frappe#44799)) ([frappe#44805](frappe#44805)) ([ad57e33](frappe@ad57e33)) * stock entry not fetching expired batches (backport [frappe#44863](frappe#44863)) ([frappe#44868](frappe#44868)) ([d6001e5](frappe@d6001e5)) * Stock Entry uses incorrect company when generated from Pick List ([frappe#44679](frappe#44679)) ([58e8467](frappe@58e8467)) * Swedish tax templates ([cc1834b](frappe@cc1834b)) * test case correction ([ddfead2](frappe@ddfead2)) * typerror on TDS payable monthly report (backport [frappe#37707](frappe#37707)) ([db9a319](frappe@db9a319)) * update correct cost center in Accounts Receivable Report ([4c5540a](frappe@4c5540a)) * update query ([3ab4acf](frappe@3ab4acf)) * use utility method to generate url ([75aee42](frappe@75aee42)) * **ux:** purchase invoice link in error message ([frappe#44797](frappe#44797)) ([01c1ed9](frappe@01c1ed9)) * Warehouse wise Stock Value chart roles (backport [frappe#44865](frappe#44865)) ([frappe#44867](frappe#44867)) ([f32cf84](frappe@f32cf84)) ### Features * add difference_posting_date field ([bec1f97](frappe@bec1f97)) * **subcontracting:** Added provision to create multiple Subcontracting Orders against a single Purchase Order (backport [frappe#44711](frappe#44711)) ([frappe#44782](frappe#44782)) ([8f81172](frappe@8f81172)) * swedish COA ([98cc79d](frappe@98cc79d)) * use difference_posting_date for journal entry posting_date ([7498cdf](frappe@7498cdf)) ### Performance Improvements * SABB (backport [frappe#44764](frappe#44764)) ([frappe#44789](frappe#44789)) ([b706a82](frappe@b706a82)) * slow query related to stock ledger entry (backport [frappe#44861](frappe#44861)) ([frappe#44862](frappe#44862)) ([3f3df7e](frappe@3f3df7e))
…pe#44910) (frappe#44913) fix: allow zero valuation rate (backport frappe#44902) (frappe#44910) fix: allow zero valuation rate (frappe#44902) (cherry picked from commit 614a8f1) Co-authored-by: rohitwaghchaure <[email protected]> (cherry picked from commit 9060e4c) Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
## [15.47.1](frappe/erpnext@v15.47.0...v15.47.1) (2024-12-26) ### Bug Fixes * allow zero valuation rate (backport [frappe#44902](frappe#44902)) (backport [frappe#44910](frappe#44910)) ([frappe#44913](frappe#44913)) ([763951a](frappe@763951a))
chore: release v15
## [15.47.2](frappe/erpnext@v15.47.1...v15.47.2) (2025-01-01) ### Bug Fixes * add company filter to project ([d550b43](frappe@d550b43)) * allow zero valuation rate (backport [frappe#44902](frappe#44902)) ([frappe#44910](frappe#44910)) ([9060e4c](frappe@9060e4c)) * apply apply_pricing_rule date change ([f09acc7](frappe@f09acc7)) * apply discount on qty change ([c19725c](frappe@c19725c)) * clear payment schedule in purchase invoice for is_paid ([6cc7060](frappe@6cc7060)) * copy accounting dimensions to asset and sales invoice ([frappe#44964](frappe#44964)) ([839ffb3](frappe@839ffb3)) * duplicate validate for closing stock balance ([frappe#45015](frappe#45015)) ([8d650e5](frappe@8d650e5)) * failing tests fixed ([61367ee](frappe@61367ee)) * fetch advance payment entries on pos invoice (backport [frappe#44856](frappe#44856)) ([frappe#44931](frappe#44931)) ([cc827c8](frappe@cc827c8)) * fetch amount in company currency ([b135a68](frappe@b135a68)) * get item tax template based on posting date ([2feeebb](frappe@2feeebb)) * ignore duplicate while creating default templates ([6c206c1](frappe@6c206c1)) * ignore inventory dimension for SABB and Pick List (backport [frappe#44933](frappe#44933)) ([frappe#44941](frappe#44941)) ([772b7b9](frappe@772b7b9)) * ignore validate while making WO from MR (backport [frappe#44939](frappe#44939)) ([frappe#44942](frappe#44942)) ([c33e075](frappe@c33e075)) * in_contex_translation_fixes ([1353a14](frappe@1353a14)) * include company in filter condition ([7422043](frappe@7422043)) * incorrect filter for BOM (backport [frappe#44954](frappe#44954)) ([frappe#44956](frappe#44956)) ([9853bd9](frappe@9853bd9)) * incorrect quality inspection linked in purchase receipt (backport [frappe#44985](frappe#44985)) ([frappe#45020](frappe#45020)) ([0a2cc6b](frappe@0a2cc6b)) * limit discount value to 100 in pos cart (backport [frappe#44916](frappe#44916)) ([frappe#44932](frappe#44932)) ([28442f3](frappe@28442f3)) * load customer default price list in pos during item selection (backport [frappe#44991](frappe#44991)) ([frappe#44993](frappe#44993)) ([20efe7b](frappe@20efe7b)) * material request status (backport [frappe#44917](frappe#44917)) ([frappe#44918](frappe#44918)) ([042d12b](frappe@042d12b)) * move code from purchase invoice to buying controller ([98631eb](frappe@98631eb)) * negative stock balance (backport [frappe#44990](frappe#44990)) ([frappe#44996](frappe#44996)) ([6f71389](frappe@6f71389)) * not able to make purchase receipt from SCR (backport [frappe#44919](frappe#44919)) ([frappe#44925](frappe#44925)) ([c241262](frappe@c241262)) * pos payment using non-default mode of payment (backport [frappe#44920](frappe#44920)) ([frappe#44971](frappe#44971)) ([7dd2b0c](frappe@7dd2b0c)), closes [frappe#41108](frappe#41108) * precision issue (backport [frappe#45013](frappe#45013)) ([frappe#45019](frappe#45019)) ([52bdf5b](frappe@52bdf5b)) * refactor query in get_total_allocated_amount in bank_transaction ([944dc96](frappe@944dc96)) * relabel rate to tax rate ([991a336](frappe@991a336)) * remove unused variable ([b892282](frappe@b892282)) * **report:** Purchase Order Analysis pymysql.err (backport [frappe#44957](frappe#44957)) ([frappe#44994](frappe#44994)) ([ea4b6e8](frappe@ea4b6e8)) * resolved conflicts ([00ae829](frappe@00ae829)) * set paid amount in party currency in bank reco payment entry ([6703a45](frappe@6703a45)) * set/update billing address on change of company ([cfa432d](frappe@cfa432d)) * Show order tax amount in customer currency on the portal (backport [frappe#44915](frappe#44915)) ([frappe#44923](frappe#44923)) ([5cc9e10](frappe@5cc9e10)) * SQL syntax error in Purchase Receipt query for empty filters ([frappe#44636](frappe#44636)) ([2f279a6](frappe@2f279a6)) * strings for translation (backport [frappe#44816](frappe#44816)) ([frappe#44927](frappe#44927)) ([488d808](frappe@488d808)) * update item_tax_rate in backend ([8885b07](frappe@8885b07)) * use meta to check field instead of doctype ([e582ff8](frappe@e582ff8)) * Validate party on non receivable / payable account (backport [frappe#44883](frappe#44883)) ([frappe#44973](frappe#44973)) ([d6903fb](frappe@d6903fb)) * whitespace ([2efc701](frappe@2efc701))
fix: slow stock transactions (frappe#45025) (cherry picked from commit e92af10) Co-authored-by: rohitwaghchaure <[email protected]> (cherry picked from commit 85ba96e)
…45027 fix: slow stock transactions (backport frappe#45025) (backport frappe#45027)
## [15.47.3](frappe/erpnext@v15.47.2...v15.47.3) (2025-01-01) ### Bug Fixes * slow stock transactions (backport [frappe#45025](frappe#45025)) ([frappe#45027](frappe#45027)) ([bb75adb](frappe@bb75adb))
(cherry picked from commit 63d547f)
…45056 chore: partial revert frappe#44989 (backport frappe#45056)
chore: release v15
## [15.47.4](frappe/erpnext@v15.47.3...v15.47.4) (2025-01-03) ### Bug Fixes * Added patch and fallback code to prevent future issues similiar to helpdesk ticket 28246 ([ab87265](frappe@ab87265)) * Added patch and fallback code to prevent future issues similiar to helpdesk ticket 28246 ([66544bf](frappe@66544bf)) * BOM cost update issue ([00102a1](frappe@00102a1)) * Fixed logic in if condition causing tests to fail ([b3b8083](frappe@b3b8083)) * Removed patch as instructed by mentor ([3049027](frappe@3049027)) * Removed patch as instructed by mentor ([163af91](frappe@163af91)) * removed unknown patch? ([f9d038e](frappe@f9d038e)) * removed unused code ([d31b0a5](frappe@d31b0a5)) * slow stock transactions (backport [frappe#45025](frappe#45025)) ([frappe#45027](frappe#45027)) ([85ba96e](frappe@85ba96e)) * **style:** set image width in BOM ([6247d5a](frappe@6247d5a)) * validate components and their qty as per BOM in the stock entry ([b5f6926](frappe@b5f6926))
…it was always picking the session default company which fails in multi-company setup.
basant-in
requested review from
deepeshgarg007 and
rohitwaghchaure
as code owners
January 4, 2025 12:30
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added company in Repost Entry From SLE Document. In the absense of this, it was always picking the session default company which fails in multi-company setup.