Skip to content

Commit 3771c6e

Browse files
fix: consider zero valuation rate for serial nos (backport frappe#44532) (frappe#44534)
fix: consider zero valuation rate for serial nos (frappe#44532) (cherry picked from commit 14f2b0a) Co-authored-by: rohitwaghchaure <[email protected]>
1 parent f4aa4c9 commit 3771c6e

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

erpnext/stock/serial_batch_bundle.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -508,7 +508,7 @@ def calculate_stock_value_change(self):
508508
serial_nos = self.get_serial_nos()
509509
for serial_no in serial_nos:
510510
incoming_rate = self.get_incoming_rate_from_bundle(serial_no)
511-
if not incoming_rate:
511+
if incoming_rate is None:
512512
continue
513513

514514
self.stock_value_change += incoming_rate
@@ -553,7 +553,7 @@ def get_incoming_rate_from_bundle(self, serial_no) -> float:
553553
query = query.where(timestamp_condition)
554554

555555
incoming_rate = query.run()
556-
return flt(incoming_rate[0][0]) if incoming_rate else 0.0
556+
return flt(incoming_rate[0][0]) if incoming_rate else None
557557

558558
def get_serial_nos(self):
559559
if self.sle.get("serial_nos"):

0 commit comments

Comments
 (0)