fix: handle zero salvage value case

khushi8112 · khushi8112 · commit 632a45d82e60 · 2024-12-17T11:37:05.000+05:30
diff --git a/erpnext/assets/doctype/asset/asset.py b/erpnext/assets/doctype/asset/asset.py
@@ -805,6 +805,9 @@ def get_depreciation_rate(self, args, on_validate=False):
 				return args.get("rate_of_depreciation")
 
 			if self.flags.increase_in_asset_value_due_to_repair:
+				if not flt(args.get("expected_value_after_useful_life")):
+					return args.get("rate_of_depreciation")
+
 				value = flt(args.get("expected_value_after_useful_life")) / flt(
 					args.get("value_after_depreciation")
 				)

Original file line number	Diff line number	Diff line change
`@@ -805,6 +805,9 @@ def get_depreciation_rate(self, args, on_validate=False):`
`805`	`805`	`return args.get("rate_of_depreciation")`
`806`	`806`
`807`	`807`	`if self.flags.increase_in_asset_value_due_to_repair:`
	`808`	`+ if not flt(args.get("expected_value_after_useful_life")):`
	`809`	`+ return args.get("rate_of_depreciation")`
	`810`	`+`
`808`	`811`	`value = flt(args.get("expected_value_after_useful_life")) / flt(`
`809`	`812`	`args.get("value_after_depreciation")`
`810`	`813`	`)`