fix: Fixed logic in if condition causing tests to fail

mihir-kandoi · mergify[bot] · commit b3b808335f34 · 2025-01-01T11:06:27.000Z
(cherry picked from commit 575fb43)
diff --git a/erpnext/controllers/subcontracting_controller.py b/erpnext/controllers/subcontracting_controller.py
@@ -104,7 +104,7 @@ def validate_items(self):
 					)
 
 				if (
-					not item.sc_conversion_factor
+					self.doctype == "Subcontracting Order" and not item.sc_conversion_factor
 				):  # this condition will only be true if user has recently updated from develop branch
 					service_item_qty = frappe.get_value(
 						"Subcontracting Order Service Item",

Original file line number	Diff line number	Diff line change
`@@ -104,7 +104,7 @@ def validate_items(self):`
`104`	`104`	`)`
`105`	`105`
`106`	`106`	`if (`
`107`		`- not item.sc_conversion_factor`
	`107`	`+ self.doctype == "Subcontracting Order" and not item.sc_conversion_factor`
`108`	`108`	`): # this condition will only be true if user has recently updated from develop branch`
`109`	`109`	`service_item_qty = frappe.get_value(`
`110`	`110`	`"Subcontracting Order Service Item",`