Skip to content

Commit

Permalink
fix: Added patch and fallback code to prevent future issues similiar …
Browse files Browse the repository at this point in the history
…to helpdesk ticket 28246
  • Loading branch information
mihir-kandoi committed Jan 1, 2025
1 parent 163af91 commit ab87265
Show file tree
Hide file tree
Showing 2 changed files with 26 additions and 8 deletions.
8 changes: 0 additions & 8 deletions erpnext/patches.txt
Original file line number Diff line number Diff line change
Expand Up @@ -386,12 +386,4 @@ erpnext.patches.v14_0.update_stock_uom_in_work_order_item
erpnext.patches.v15_0.set_is_exchange_gain_loss_in_payment_entry_deductions
erpnext.patches.v15_0.enable_allow_existing_serial_no
erpnext.patches.v15_0.update_cc_in_process_statement_of_accounts
<<<<<<< HEAD
<<<<<<< HEAD
=======
erpnext.patches.v15_0.refactor_closing_stock_balance #5
erpnext.subcontracting.doctype.subcontracting_order.patches.set_sc_conversion_factor
>>>>>>> 65dc3505c4 (fix: Added patch and fallback code to prevent future issues similiar to helpdesk ticket 28246)
=======
erpnext.patches.v15_0.refactor_closing_stock_balance #5
>>>>>>> d1d01482df (fix: Removed patch as instructed by mentor)
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
import frappe


def execute():
# Calculate and set sc_conversion_factor for draft Subcontracting Orders if value is 0

subcontracting_order_items = frappe.get_all(
"Subcontracting Order Item",
filters={"docstatus": 0, "sc_conversion_factor": 0},
fields=["name", "parent", "purchase_order_item", "qty"],
)
for subcontracting_order_item in subcontracting_order_items:
service_item_qty = frappe.get_value(
"Subcontracting Order Service Item",
filters={
"purchase_order_item": subcontracting_order_item.purchase_order_item,
"parent": subcontracting_order_item.parent,
},
fieldname=["qty"],
)
frappe.set_value(
"Subcontracting Order Item",
subcontracting_order_item.name,
"sc_conversion_factor",
service_item_qty / subcontracting_order_item.qty,
)

0 comments on commit ab87265

Please sign in to comment.