Clean up unused code from Connection.php#3071
Closed
ajello-meta wants to merge 3 commits intomainfrom
Closed
Conversation
added 2 commits
April 18, 2025 15:06
Contributor
|
@ajello-meta has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@ajello-meta merged this pull request in 2e57f1e. |
mradmeta
pushed a commit
that referenced
this pull request
Apr 19, 2025
Summary: ## Description This PR removes unused code in `Connection.php` that related to enhanced onboarding. In #2968, we introduced the enhanced settings UI, which completely revamped all extension settings using `Enhanced_Settings.php`. The logic that was deleted here is available in `Shops.php`. ### Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [x] Syntax change (non-breaking change which fixes code modularity, linting or phpcs issues) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) Pull Request resolved: #3071 Test Plan: 1. Go to `http://test-site-i.local/wp-admin/admin.php?page=wc-facebook`. Make sure you are seeing the legacy setting UI. 2. Go to the "Connection" tab and test the functionality. Make sure to test the UI in both the connected state and non-connected state. **!---- (auto-generated) DO NOT EDIT OR PUT ANYTHING AFTER THIS LINE ----!** MFTRunTestsScript Run / Test Suite: sa_checkout / Test Collection: www / Diff Version V1 https://internalfb.com/intern/testinfra/testrun/1125900319629707 MFTRunTestsScript Run / Test Suite: sa_checkout / Test Collection: bloks / Diff Version V1 https://internalfb.com/intern/testinfra/testrun/12947849007730003 Reviewed By: jczhuoMeta Differential Revision: D73272875 Pulled By: ajello-meta fbshipit-source-id: 2a6f3bf6cd96a1260d966b2ac0459863b388038a
mradmeta
pushed a commit
to mradmeta/facebook-for-woocommerce
that referenced
this pull request
Apr 22, 2025
Summary: ## Description This PR removes unused code in `Connection.php` that related to enhanced onboarding. In facebook#2968, we introduced the enhanced settings UI, which completely revamped all extension settings using `Enhanced_Settings.php`. The logic that was deleted here is available in `Shops.php`. ### Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [x] Syntax change (non-breaking change which fixes code modularity, linting or phpcs issues) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) Pull Request resolved: facebook#3071 Test Plan: 1. Go to `http://test-site-i.local/wp-admin/admin.php?page=wc-facebook`. Make sure you are seeing the legacy setting UI. 2. Go to the "Connection" tab and test the functionality. Make sure to test the UI in both the connected state and non-connected state. **!---- (auto-generated) DO NOT EDIT OR PUT ANYTHING AFTER THIS LINE ----!** MFTRunTestsScript Run / Test Suite: sa_checkout / Test Collection: www / Diff Version V1 https://internalfb.com/intern/testinfra/testrun/1125900319629707 MFTRunTestsScript Run / Test Suite: sa_checkout / Test Collection: bloks / Diff Version V1 https://internalfb.com/intern/testinfra/testrun/12947849007730003 Reviewed By: jczhuoMeta Differential Revision: D73272875 Pulled By: ajello-meta fbshipit-source-id: 2a6f3bf6cd96a1260d966b2ac0459863b388038a
This was referenced Apr 23, 2025
This was referenced May 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes unused code in
Connection.phpthat related to enhanced onboarding. In #2968, we introduced the enhanced settings UI, which completely revamped all extension settings usingEnhanced_Settings.php. The logic that was deleted here is available inShops.php.Type of change
Test Plan
http://test-site-i.local/wp-admin/admin.php?page=wc-facebook. Make sure you are seeing the legacy setting UI.