Conversation
Contributor
|
@vinkmeta has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
vahidkay-meta
pushed a commit
that referenced
this pull request
Apr 14, 2025
Summary: ## Description Updated PR template ### Type of change Please delete options that are not relevant. - Syntax change (non-breaking change which fixes code modularity, linting or phpcs issues) ## Checklist - [x] I have commented my code, particularly in hard-to-understand areas. - [x] I have confirmed that my changes do not introduce any new PHPCS warnings or errors. - [x] I followed general Pull Request best practices. Meta employees to follow this [wiki]([url](https://fburl.com/wiki/2cgfduwc)). - [x] I have added tests (if necessary) and all the new and existing unit tests pass locally with my changes. - [x] I have completed dogfooding and QA testing, or I have conducted thorough due diligence to ensure that it does not break existing functionality. - [x] I have updated or requested update to plugin documentations (if necessary). Meta employees to follow this [wiki]([url](https://fburl.com/wiki/nhx73tgs)). ## Changelog entry Updated PR template Pull Request resolved: #3053 Differential Revision: D72936088 Pulled By: vinkmeta fbshipit-source-id: edcd0143efdfab8f522f76db72bee49bc40314ab
mradmeta
pushed a commit
that referenced
this pull request
Apr 14, 2025
Summary: ## Description Updated PR template ### Type of change Please delete options that are not relevant. - Syntax change (non-breaking change which fixes code modularity, linting or phpcs issues) ## Checklist - [x] I have commented my code, particularly in hard-to-understand areas. - [x] I have confirmed that my changes do not introduce any new PHPCS warnings or errors. - [x] I followed general Pull Request best practices. Meta employees to follow this [wiki]([url](https://fburl.com/wiki/2cgfduwc)). - [x] I have added tests (if necessary) and all the new and existing unit tests pass locally with my changes. - [x] I have completed dogfooding and QA testing, or I have conducted thorough due diligence to ensure that it does not break existing functionality. - [x] I have updated or requested update to plugin documentations (if necessary). Meta employees to follow this [wiki]([url](https://fburl.com/wiki/nhx73tgs)). ## Changelog entry Updated PR template Pull Request resolved: #3053 Differential Revision: D72936088 Pulled By: vinkmeta fbshipit-source-id: edcd0143efdfab8f522f76db72bee49bc40314ab
rubycalling
pushed a commit
that referenced
this pull request
Apr 16, 2025
Summary: ## Description Updated PR template ### Type of change Please delete options that are not relevant. - Syntax change (non-breaking change which fixes code modularity, linting or phpcs issues) ## Checklist - [x] I have commented my code, particularly in hard-to-understand areas. - [x] I have confirmed that my changes do not introduce any new PHPCS warnings or errors. - [x] I followed general Pull Request best practices. Meta employees to follow this [wiki]([url](https://fburl.com/wiki/2cgfduwc)). - [x] I have added tests (if necessary) and all the new and existing unit tests pass locally with my changes. - [x] I have completed dogfooding and QA testing, or I have conducted thorough due diligence to ensure that it does not break existing functionality. - [x] I have updated or requested update to plugin documentations (if necessary). Meta employees to follow this [wiki]([url](https://fburl.com/wiki/nhx73tgs)). ## Changelog entry Updated PR template Pull Request resolved: #3053 Differential Revision: D72936088 Pulled By: vinkmeta fbshipit-source-id: edcd0143efdfab8f522f76db72bee49bc40314ab
Merged
This was referenced Apr 18, 2025
This was referenced May 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updated PR template
Type of change
Please delete options that are not relevant.
Checklist
Changelog entry
Updated PR template