Feature: Short Description Fallback#3048
Closed
devbodaghe wants to merge 3 commits intofacebook:mainfrom
Closed
Conversation
Contributor
|
@devbodaghe has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@devbodaghe has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@devbodaghe merged this pull request in 6c768e4. |
mradmeta
pushed a commit
that referenced
this pull request
Apr 14, 2025
Summary: ## Feature: Short Description Fallback This pull request introduces a new feature to the `WC_Facebook_Product` class, specifically enhancing the `get_fb_short_description` method. The method now includes logic to use the main product description as the short description when the main description is less than 50 characters. ### Changes - **Modified `get_fb_short_description` Method:** - For variation products, if no short description is found, the method now checks if the main description is less than 50 characters and uses it as the short description. - For regular products, if no short description (excerpt) is found, the method checks if the main description is less than 50 characters and uses it as the short description. ### Benefits - Ensures that products with very short main descriptions can still have a meaningful short description. - Improves the consistency and completeness of product data sent to Facebook. ### Testing - Verified that the short description is correctly populated from the main description when it is less than 50 characters. - Ensured that existing functionality remains unaffected for products with longer descriptions. ### Notes - This change does not affect any other parts of the plugin and maintains backward compatibility. Pull Request resolved: #3048 Reviewed By: vinkmeta Differential Revision: D72866715 Pulled By: devbodaghe fbshipit-source-id: 87fe2e362dcc025b2633894f930afa9cbd9a174d
rubycalling
pushed a commit
that referenced
this pull request
Apr 16, 2025
Summary: ## Feature: Short Description Fallback This pull request introduces a new feature to the `WC_Facebook_Product` class, specifically enhancing the `get_fb_short_description` method. The method now includes logic to use the main product description as the short description when the main description is less than 50 characters. ### Changes - **Modified `get_fb_short_description` Method:** - For variation products, if no short description is found, the method now checks if the main description is less than 50 characters and uses it as the short description. - For regular products, if no short description (excerpt) is found, the method checks if the main description is less than 50 characters and uses it as the short description. ### Benefits - Ensures that products with very short main descriptions can still have a meaningful short description. - Improves the consistency and completeness of product data sent to Facebook. ### Testing - Verified that the short description is correctly populated from the main description when it is less than 50 characters. - Ensured that existing functionality remains unaffected for products with longer descriptions. ### Notes - This change does not affect any other parts of the plugin and maintains backward compatibility. Pull Request resolved: #3048 Reviewed By: vinkmeta Differential Revision: D72866715 Pulled By: devbodaghe fbshipit-source-id: 87fe2e362dcc025b2633894f930afa9cbd9a174d
This was referenced Apr 18, 2025
carterbuce
pushed a commit
to carterbuce/facebook-for-woocommerce
that referenced
this pull request
Apr 24, 2025
Summary: ## Feature: Short Description Fallback This pull request introduces a new feature to the `WC_Facebook_Product` class, specifically enhancing the `get_fb_short_description` method. The method now includes logic to use the main product description as the short description when the main description is less than 50 characters. ### Changes - **Modified `get_fb_short_description` Method:** - For variation products, if no short description is found, the method now checks if the main description is less than 50 characters and uses it as the short description. - For regular products, if no short description (excerpt) is found, the method checks if the main description is less than 50 characters and uses it as the short description. ### Benefits - Ensures that products with very short main descriptions can still have a meaningful short description. - Improves the consistency and completeness of product data sent to Facebook. ### Testing - Verified that the short description is correctly populated from the main description when it is less than 50 characters. - Ensured that existing functionality remains unaffected for products with longer descriptions. ### Notes - This change does not affect any other parts of the plugin and maintains backward compatibility. Pull Request resolved: facebook#3048 Reviewed By: vinkmeta Differential Revision: D72866715 Pulled By: devbodaghe fbshipit-source-id: 87fe2e362dcc025b2633894f930afa9cbd9a174d (cherry picked from commit 6c768e4)
carterbuce
pushed a commit
to carterbuce/facebook-for-woocommerce
that referenced
this pull request
Apr 24, 2025
Summary: ## Feature: Short Description Fallback This pull request introduces a new feature to the `WC_Facebook_Product` class, specifically enhancing the `get_fb_short_description` method. The method now includes logic to use the main product description as the short description when the main description is less than 50 characters. ### Changes - **Modified `get_fb_short_description` Method:** - For variation products, if no short description is found, the method now checks if the main description is less than 50 characters and uses it as the short description. - For regular products, if no short description (excerpt) is found, the method checks if the main description is less than 50 characters and uses it as the short description. ### Benefits - Ensures that products with very short main descriptions can still have a meaningful short description. - Improves the consistency and completeness of product data sent to Facebook. ### Testing - Verified that the short description is correctly populated from the main description when it is less than 50 characters. - Ensured that existing functionality remains unaffected for products with longer descriptions. ### Notes - This change does not affect any other parts of the plugin and maintains backward compatibility. Pull Request resolved: facebook#3048 Reviewed By: vinkmeta Differential Revision: D72866715 Pulled By: devbodaghe fbshipit-source-id: 87fe2e362dcc025b2633894f930afa9cbd9a174d (cherry picked from commit 6c768e4)
Closed
tzahgr
pushed a commit
that referenced
this pull request
Apr 24, 2025
Summary: ## Feature: Short Description Fallback This pull request introduces a new feature to the `WC_Facebook_Product` class, specifically enhancing the `get_fb_short_description` method. The method now includes logic to use the main product description as the short description when the main description is less than 50 characters. ### Changes - **Modified `get_fb_short_description` Method:** - For variation products, if no short description is found, the method now checks if the main description is less than 50 characters and uses it as the short description. - For regular products, if no short description (excerpt) is found, the method checks if the main description is less than 50 characters and uses it as the short description. ### Benefits - Ensures that products with very short main descriptions can still have a meaningful short description. - Improves the consistency and completeness of product data sent to Facebook. ### Testing - Verified that the short description is correctly populated from the main description when it is less than 50 characters. - Ensured that existing functionality remains unaffected for products with longer descriptions. ### Notes - This change does not affect any other parts of the plugin and maintains backward compatibility. Pull Request resolved: #3048 Reviewed By: vinkmeta Differential Revision: D72866715 Pulled By: devbodaghe fbshipit-source-id: 87fe2e362dcc025b2633894f930afa9cbd9a174d
This was referenced May 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature: Short Description Fallback
Summary
This pull request introduces a new feature to the
WC_Facebook_Productclass, specifically enhancing theget_fb_short_descriptionmethod. The method now includes logic to use the main product description as the short description when the main description is less than 50 characters.Changes
get_fb_short_descriptionMethod:Benefits
Testing
Notes