fix: mismatch between tooltip messages for Skirt Length and Sleeve Le…#3039
Closed
devbodaghe wants to merge 1 commit intofacebook:mainfrom
Closed
fix: mismatch between tooltip messages for Skirt Length and Sleeve Le…#3039devbodaghe wants to merge 1 commit intofacebook:mainfrom
devbodaghe wants to merge 1 commit intofacebook:mainfrom
Conversation
Contributor
|
@devbodaghe has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@devbodaghe merged this pull request in c8de262. |
Closed
6 tasks
vinkmeta
pushed a commit
that referenced
this pull request
Apr 13, 2025
#3039) Summary: allow-large-files # Fix Tooltip Messages for Skirt Length and Sleeve Length ## Issue The tooltip messages for Skirt Length and Sleeve Length were incorrectly swapped, causing confusion for users. ## Changes - Corrected tooltip text for Skirt Length to properly describe skirt measurements - Corrected tooltip text for Sleeve Length to properly describe sleeve measurements ## Testing - Verified tooltips display correct information when hovering over each field <img width="578" alt="Screenshot 2025-04-10 at 16 00 09" src="https://github.com/user-attachments/assets/d9fd58fe-fefa-4f6c-8325-544c825bd1aa" /> <img width="470" alt="Screenshot 2025-04-10 at 16 00 00" src="https://github.com/user-attachments/assets/5f9fd8c1-3d73-40fb-bcce-c89b9e9b83d2" /> Pull Request resolved: #3039 Reviewed By: SayanPandey, gurtejrehal Differential Revision: D72794796 Pulled By: devbodaghe fbshipit-source-id: f4acad7cdd227bacdbd6b9facda4612da9f2c705
This was referenced Apr 14, 2025
Closed
mradmeta
pushed a commit
that referenced
this pull request
Apr 14, 2025
#3039) Summary: allow-large-files # Fix Tooltip Messages for Skirt Length and Sleeve Length ## Issue The tooltip messages for Skirt Length and Sleeve Length were incorrectly swapped, causing confusion for users. ## Changes - Corrected tooltip text for Skirt Length to properly describe skirt measurements - Corrected tooltip text for Sleeve Length to properly describe sleeve measurements ## Testing - Verified tooltips display correct information when hovering over each field <img width="578" alt="Screenshot 2025-04-10 at 16 00 09" src="https://github.com/user-attachments/assets/d9fd58fe-fefa-4f6c-8325-544c825bd1aa" /> <img width="470" alt="Screenshot 2025-04-10 at 16 00 00" src="https://github.com/user-attachments/assets/5f9fd8c1-3d73-40fb-bcce-c89b9e9b83d2" /> Pull Request resolved: #3039 Reviewed By: SayanPandey, gurtejrehal Differential Revision: D72794796 Pulled By: devbodaghe fbshipit-source-id: f4acad7cdd227bacdbd6b9facda4612da9f2c705
vahidkay-meta
pushed a commit
that referenced
this pull request
Apr 15, 2025
#3039) Summary: allow-large-files # Fix Tooltip Messages for Skirt Length and Sleeve Length ## Issue The tooltip messages for Skirt Length and Sleeve Length were incorrectly swapped, causing confusion for users. ## Changes - Corrected tooltip text for Skirt Length to properly describe skirt measurements - Corrected tooltip text for Sleeve Length to properly describe sleeve measurements ## Testing - Verified tooltips display correct information when hovering over each field <img width="578" alt="Screenshot 2025-04-10 at 16 00 09" src="https://github.com/user-attachments/assets/d9fd58fe-fefa-4f6c-8325-544c825bd1aa" /> <img width="470" alt="Screenshot 2025-04-10 at 16 00 00" src="https://github.com/user-attachments/assets/5f9fd8c1-3d73-40fb-bcce-c89b9e9b83d2" /> Pull Request resolved: #3039 Reviewed By: SayanPandey, gurtejrehal Differential Revision: D72794796 Pulled By: devbodaghe fbshipit-source-id: f4acad7cdd227bacdbd6b9facda4612da9f2c705
rubycalling
pushed a commit
that referenced
this pull request
Apr 16, 2025
#3039) Summary: allow-large-files # Fix Tooltip Messages for Skirt Length and Sleeve Length ## Issue The tooltip messages for Skirt Length and Sleeve Length were incorrectly swapped, causing confusion for users. ## Changes - Corrected tooltip text for Skirt Length to properly describe skirt measurements - Corrected tooltip text for Sleeve Length to properly describe sleeve measurements ## Testing - Verified tooltips display correct information when hovering over each field <img width="578" alt="Screenshot 2025-04-10 at 16 00 09" src="https://github.com/user-attachments/assets/d9fd58fe-fefa-4f6c-8325-544c825bd1aa" /> <img width="470" alt="Screenshot 2025-04-10 at 16 00 00" src="https://github.com/user-attachments/assets/5f9fd8c1-3d73-40fb-bcce-c89b9e9b83d2" /> Pull Request resolved: #3039 Reviewed By: SayanPandey, gurtejrehal Differential Revision: D72794796 Pulled By: devbodaghe fbshipit-source-id: f4acad7cdd227bacdbd6b9facda4612da9f2c705
Merged
This was referenced Apr 18, 2025
This was referenced May 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Tooltip Messages for Skirt Length and Sleeve Length
Issue
The tooltip messages for Skirt Length and Sleeve Length were incorrectly swapped, causing confusion for users.
Changes
Testing