Closed
Conversation
Contributor
|
@raymon1 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
raymon1
force-pushed
the
feature/truncate_title_description
branch
from
2d4cd11 to
46a8728
Compare
Contributor
|
@raymon1 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
Closed
6 tasks
vinkmeta
pushed a commit
that referenced
this pull request
Apr 13, 2025
Summary: ## Description in #2969 the validations were relaxed, this might cause some backend issues. In this diff, in order to sync products, we are truncating any extra characters form the title and description ### Type of change - New feature (non-breaking change which adds functionality) ## Checklist - [X] I have commented my code, particularly in hard-to-understand areas. - [X] I have confirmed that my changes do not introduce any new PHPCS warnings or errors. - [X] I followed general Pull Request best practices. Meta employees to follow this [wiki]([url](https://fburl.com/wiki/2cgfduwc)). - [X] I have added tests (if necessary) and all the new and existing unit tests pass locally with my changes. - [X] I have completed dogfooding and QA testing, or I have conducted thorough due diligence to ensure that it does not break existing functionality. - [X] I have updated or requested update to plugin documentations (if necessary). Meta employees to follow this [wiki]([url](https://fburl.com/wiki/nhx73tgs)). ## Changelog entry Truncates extra characters from title and description Pull Request resolved: #3023 Test Plan: Create item with more than the limits of 150 character for title and more than 5000 for description Before: The title/description will be missing if both title and description are above limit, the item won't be synced After: Truncates (title/description) <img width="2056" alt="image" src="https://github.com/user-attachments/assets/4eb494c7-d070-485a-8b6d-e9ff187fedfb" /> synced <img width="2056" alt="image" src="https://github.com/user-attachments/assets/01b0a61d-3fe2-4a92-9a01-e2e263ad76a5" /> ## Screenshots Please provide screenshots or snapshots of the system/state both before and after implementing the changes, if appropriate ### Before ### After Reviewed By: vinkmeta, SayanPandey Differential Revision: D72567584 Pulled By: raymon1 fbshipit-source-id: 17a6b279f1a3ce5d55237b885c3d349b9b6abdfb
vahidkay-meta
pushed a commit
that referenced
this pull request
Apr 14, 2025
Summary: ## Description in #2969 the validations were relaxed, this might cause some backend issues. In this diff, in order to sync products, we are truncating any extra characters form the title and description ### Type of change - New feature (non-breaking change which adds functionality) ## Checklist - [X] I have commented my code, particularly in hard-to-understand areas. - [X] I have confirmed that my changes do not introduce any new PHPCS warnings or errors. - [X] I followed general Pull Request best practices. Meta employees to follow this [wiki]([url](https://fburl.com/wiki/2cgfduwc)). - [X] I have added tests (if necessary) and all the new and existing unit tests pass locally with my changes. - [X] I have completed dogfooding and QA testing, or I have conducted thorough due diligence to ensure that it does not break existing functionality. - [X] I have updated or requested update to plugin documentations (if necessary). Meta employees to follow this [wiki]([url](https://fburl.com/wiki/nhx73tgs)). ## Changelog entry Truncates extra characters from title and description Pull Request resolved: #3023 Test Plan: Create item with more than the limits of 150 character for title and more than 5000 for description Before: The title/description will be missing if both title and description are above limit, the item won't be synced After: Truncates (title/description) <img width="2056" alt="image" src="https://github.com/user-attachments/assets/4eb494c7-d070-485a-8b6d-e9ff187fedfb" /> synced <img width="2056" alt="image" src="https://github.com/user-attachments/assets/01b0a61d-3fe2-4a92-9a01-e2e263ad76a5" /> ## Screenshots Please provide screenshots or snapshots of the system/state both before and after implementing the changes, if appropriate ### Before ### After Reviewed By: vinkmeta, SayanPandey Differential Revision: D72567584 Pulled By: raymon1 fbshipit-source-id: 17a6b279f1a3ce5d55237b885c3d349b9b6abdfb
This was referenced Apr 14, 2025
Closed
mradmeta
pushed a commit
that referenced
this pull request
Apr 14, 2025
Summary: ## Description in #2969 the validations were relaxed, this might cause some backend issues. In this diff, in order to sync products, we are truncating any extra characters form the title and description ### Type of change - New feature (non-breaking change which adds functionality) ## Checklist - [X] I have commented my code, particularly in hard-to-understand areas. - [X] I have confirmed that my changes do not introduce any new PHPCS warnings or errors. - [X] I followed general Pull Request best practices. Meta employees to follow this [wiki]([url](https://fburl.com/wiki/2cgfduwc)). - [X] I have added tests (if necessary) and all the new and existing unit tests pass locally with my changes. - [X] I have completed dogfooding and QA testing, or I have conducted thorough due diligence to ensure that it does not break existing functionality. - [X] I have updated or requested update to plugin documentations (if necessary). Meta employees to follow this [wiki]([url](https://fburl.com/wiki/nhx73tgs)). ## Changelog entry Truncates extra characters from title and description Pull Request resolved: #3023 Test Plan: Create item with more than the limits of 150 character for title and more than 5000 for description Before: The title/description will be missing if both title and description are above limit, the item won't be synced After: Truncates (title/description) <img width="2056" alt="image" src="https://github.com/user-attachments/assets/4eb494c7-d070-485a-8b6d-e9ff187fedfb" /> synced <img width="2056" alt="image" src="https://github.com/user-attachments/assets/01b0a61d-3fe2-4a92-9a01-e2e263ad76a5" /> ## Screenshots Please provide screenshots or snapshots of the system/state both before and after implementing the changes, if appropriate ### Before ### After Reviewed By: vinkmeta, SayanPandey Differential Revision: D72567584 Pulled By: raymon1 fbshipit-source-id: 17a6b279f1a3ce5d55237b885c3d349b9b6abdfb
rubycalling
pushed a commit
that referenced
this pull request
Apr 16, 2025
Summary: ## Description in #2969 the validations were relaxed, this might cause some backend issues. In this diff, in order to sync products, we are truncating any extra characters form the title and description ### Type of change - New feature (non-breaking change which adds functionality) ## Checklist - [X] I have commented my code, particularly in hard-to-understand areas. - [X] I have confirmed that my changes do not introduce any new PHPCS warnings or errors. - [X] I followed general Pull Request best practices. Meta employees to follow this [wiki]([url](https://fburl.com/wiki/2cgfduwc)). - [X] I have added tests (if necessary) and all the new and existing unit tests pass locally with my changes. - [X] I have completed dogfooding and QA testing, or I have conducted thorough due diligence to ensure that it does not break existing functionality. - [X] I have updated or requested update to plugin documentations (if necessary). Meta employees to follow this [wiki]([url](https://fburl.com/wiki/nhx73tgs)). ## Changelog entry Truncates extra characters from title and description Pull Request resolved: #3023 Test Plan: Create item with more than the limits of 150 character for title and more than 5000 for description Before: The title/description will be missing if both title and description are above limit, the item won't be synced After: Truncates (title/description) <img width="2056" alt="image" src="https://github.com/user-attachments/assets/4eb494c7-d070-485a-8b6d-e9ff187fedfb" /> synced <img width="2056" alt="image" src="https://github.com/user-attachments/assets/01b0a61d-3fe2-4a92-9a01-e2e263ad76a5" /> ## Screenshots Please provide screenshots or snapshots of the system/state both before and after implementing the changes, if appropriate ### Before ### After Reviewed By: vinkmeta, SayanPandey Differential Revision: D72567584 Pulled By: raymon1 fbshipit-source-id: 17a6b279f1a3ce5d55237b885c3d349b9b6abdfb
Merged
This was referenced Apr 18, 2025
This was referenced May 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
in #2969 the validations were relaxed, this might cause some backend issues. In this diff, in order to sync products, we are truncating any extra characters form the title and description
Type of change
Checklist
Changelog entry
Truncates extra characters from title and description
Test Plan
Create item with more than the limits of 150 character for title and more than 5000 for description
Before:
The title/description will be missing
if both title and description are above limit, the item won't be synced
After:
Truncates (title/description)
synced
Screenshots
Please provide screenshots or snapshots of the system/state both before and after implementing the changes, if appropriate
Before
After