Skip to content

Updated PR Template#3019

Closed
vinkmeta wants to merge 1 commit intomainfrom
vink_1
Closed

Updated PR Template#3019
vinkmeta wants to merge 1 commit intomainfrom
vink_1

Conversation

@vinkmeta
Copy link
Copy Markdown
Contributor

@vinkmeta vinkmeta commented Apr 6, 2025

Description

Updated PR Template

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I followed general Pull Request best practices. Meta employees to follow this wiki
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests and all the new and existing unit tests pass locally with my changes
  • I have completed dogfooding and QA testing, or I have conducted thorough due diligence to ensure that it does not break existing functionality.

Changelog entry

Updated PR Template

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@vinkmeta has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@vinkmeta merged this pull request in a25844f.

SayanPandey pushed a commit to SayanPandey/facebook-for-woocommerce that referenced this pull request Apr 8, 2025
Summary:
## Description

Updated PR Template

### Type of change

Please delete options that are not relevant.

- [ ] Bug fix (non-breaking change which fixes an issue)

## Checklist

- [x] I followed general Pull Request best practices. Meta employees to follow this [wiki]([url](https://fburl.com/wiki/2cgfduwc))
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] I have added tests and all the new and existing unit tests pass locally with my changes
- [x] I have completed dogfooding and QA testing, or I have conducted thorough due diligence to ensure that it does not break existing functionality.

## Changelog entry

Updated PR Template

Pull Request resolved: facebook#3019

Reviewed By: gurtejrehal

Differential Revision: D72530023

Pulled By: vinkmeta

fbshipit-source-id: aa35b6e2b23e111f8576ce8ad9382418b991647b
vinkmeta added a commit that referenced this pull request Apr 13, 2025
Summary:
## Description

Updated PR Template

### Type of change

Please delete options that are not relevant.

- [ ] Bug fix (non-breaking change which fixes an issue)

## Checklist

- [x] I followed general Pull Request best practices. Meta employees to follow this [wiki]([url](https://fburl.com/wiki/2cgfduwc))
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] I have added tests and all the new and existing unit tests pass locally with my changes
- [x] I have completed dogfooding and QA testing, or I have conducted thorough due diligence to ensure that it does not break existing functionality.

## Changelog entry

Updated PR Template

Pull Request resolved: #3019

Reviewed By: gurtejrehal

Differential Revision: D72530023

Pulled By: vinkmeta

fbshipit-source-id: aa35b6e2b23e111f8576ce8ad9382418b991647b
vahidkay-meta pushed a commit that referenced this pull request Apr 14, 2025
Summary:
## Description

Updated PR Template

### Type of change

Please delete options that are not relevant.

- [ ] Bug fix (non-breaking change which fixes an issue)

## Checklist

- [x] I followed general Pull Request best practices. Meta employees to follow this [wiki]([url](https://fburl.com/wiki/2cgfduwc))
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] I have added tests and all the new and existing unit tests pass locally with my changes
- [x] I have completed dogfooding and QA testing, or I have conducted thorough due diligence to ensure that it does not break existing functionality.

## Changelog entry

Updated PR Template

Pull Request resolved: #3019

Reviewed By: gurtejrehal

Differential Revision: D72530023

Pulled By: vinkmeta

fbshipit-source-id: aa35b6e2b23e111f8576ce8ad9382418b991647b
vahidkay-meta pushed a commit that referenced this pull request Apr 14, 2025
Summary:
## Description

Updated PR Template

### Type of change

Please delete options that are not relevant.

- [ ] Bug fix (non-breaking change which fixes an issue)

## Checklist

- [x] I followed general Pull Request best practices. Meta employees to follow this [wiki]([url](https://fburl.com/wiki/2cgfduwc))
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] I have added tests and all the new and existing unit tests pass locally with my changes
- [x] I have completed dogfooding and QA testing, or I have conducted thorough due diligence to ensure that it does not break existing functionality.

## Changelog entry

Updated PR Template

Pull Request resolved: #3019

Reviewed By: gurtejrehal

Differential Revision: D72530023

Pulled By: vinkmeta

fbshipit-source-id: aa35b6e2b23e111f8576ce8ad9382418b991647b
mradmeta pushed a commit that referenced this pull request Apr 14, 2025
Summary:
## Description

Updated PR Template

### Type of change

Please delete options that are not relevant.

- [ ] Bug fix (non-breaking change which fixes an issue)

## Checklist

- [x] I followed general Pull Request best practices. Meta employees to follow this [wiki]([url](https://fburl.com/wiki/2cgfduwc))
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] I have added tests and all the new and existing unit tests pass locally with my changes
- [x] I have completed dogfooding and QA testing, or I have conducted thorough due diligence to ensure that it does not break existing functionality.

## Changelog entry

Updated PR Template

Pull Request resolved: #3019

Reviewed By: gurtejrehal

Differential Revision: D72530023

Pulled By: vinkmeta

fbshipit-source-id: aa35b6e2b23e111f8576ce8ad9382418b991647b
rubycalling pushed a commit that referenced this pull request Apr 16, 2025
Summary:
## Description

Updated PR Template

### Type of change

Please delete options that are not relevant.

- [ ] Bug fix (non-breaking change which fixes an issue)

## Checklist

- [x] I followed general Pull Request best practices. Meta employees to follow this [wiki]([url](https://fburl.com/wiki/2cgfduwc))
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] I have added tests and all the new and existing unit tests pass locally with my changes
- [x] I have completed dogfooding and QA testing, or I have conducted thorough due diligence to ensure that it does not break existing functionality.

## Changelog entry

Updated PR Template

Pull Request resolved: #3019

Reviewed By: gurtejrehal

Differential Revision: D72530023

Pulled By: vinkmeta

fbshipit-source-id: aa35b6e2b23e111f8576ce8ad9382418b991647b
@tzahgr tzahgr mentioned this pull request Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants