Closed
Conversation
Contributor
|
@vinkmeta has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
iodic
reviewed
Apr 2, 2025
|
|
||
| $all_attributes = $category_handler->get_attributes_with_fallback_to_parent_category( $google_category_id ); | ||
|
|
||
| if( empty( $all_attributes )){ |
Collaborator
There was a problem hiding this comment.
Can you add a space after if? And around the brackets at the end of the line?
Contributor
|
@vinkmeta has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
iodic
approved these changes
Apr 2, 2025
Contributor
|
@vinkmeta has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
tzahgr
pushed a commit
that referenced
this pull request
Apr 3, 2025
Summary: ## Description Fixed PHP Warning for empty attributes when selected Google product Category doesn't have any associated attributes. In such cases simply returning the products data without enhancing it. ### Type of change - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I followed general Pull Request best practices. Meta employees to follow this [wiki]([url](https://fburl.com/wiki/2cgfduwc)) - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have added tests and all the new and existing unit tests pass locally with my changes - [x] I have completed dogfooding and QA testing, or I have conducted thorough due diligence to ensure that it does not break existing functionality. ## Changelog entry Fixed PHP Warning for empty attributes Pull Request resolved: #3001 Test Plan: npm run test:php Reviewed By: raymon1, mshymon, SayanPandey Differential Revision: D72318247 Pulled By: vinkmeta fbshipit-source-id: 81f6396cc350083643cb887ca2b4f0bec8cc6d55
tzahgr
added a commit
that referenced
this pull request
Apr 3, 2025
This was referenced Apr 3, 2025
SayanPandey
pushed a commit
to SayanPandey/facebook-for-woocommerce
that referenced
this pull request
Apr 8, 2025
Summary: ## Description Fixed PHP Warning for empty attributes when selected Google product Category doesn't have any associated attributes. In such cases simply returning the products data without enhancing it. ### Type of change - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I followed general Pull Request best practices. Meta employees to follow this [wiki]([url](https://fburl.com/wiki/2cgfduwc)) - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have added tests and all the new and existing unit tests pass locally with my changes - [x] I have completed dogfooding and QA testing, or I have conducted thorough due diligence to ensure that it does not break existing functionality. ## Changelog entry Fixed PHP Warning for empty attributes Pull Request resolved: facebook#3001 Test Plan: npm run test:php Reviewed By: raymon1, mshymon, SayanPandey Differential Revision: D72318247 Pulled By: vinkmeta fbshipit-source-id: 81f6396cc350083643cb887ca2b4f0bec8cc6d55
This was referenced Apr 10, 2025
Closed
Closed
mradmeta
pushed a commit
that referenced
this pull request
Apr 14, 2025
Summary: ## Description Fixed PHP Warning for empty attributes when selected Google product Category doesn't have any associated attributes. In such cases simply returning the products data without enhancing it. ### Type of change - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I followed general Pull Request best practices. Meta employees to follow this [wiki]([url](https://fburl.com/wiki/2cgfduwc)) - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have added tests and all the new and existing unit tests pass locally with my changes - [x] I have completed dogfooding and QA testing, or I have conducted thorough due diligence to ensure that it does not break existing functionality. ## Changelog entry Fixed PHP Warning for empty attributes Pull Request resolved: #3001 Test Plan: npm run test:php Reviewed By: raymon1, mshymon, SayanPandey Differential Revision: D72318247 Pulled By: vinkmeta fbshipit-source-id: 81f6396cc350083643cb887ca2b4f0bec8cc6d55
rubycalling
pushed a commit
that referenced
this pull request
Apr 16, 2025
Summary: ## Description Fixed PHP Warning for empty attributes when selected Google product Category doesn't have any associated attributes. In such cases simply returning the products data without enhancing it. ### Type of change - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I followed general Pull Request best practices. Meta employees to follow this [wiki]([url](https://fburl.com/wiki/2cgfduwc)) - [x] I have commented my code, particularly in hard-to-understand areas - [x] I have added tests and all the new and existing unit tests pass locally with my changes - [x] I have completed dogfooding and QA testing, or I have conducted thorough due diligence to ensure that it does not break existing functionality. ## Changelog entry Fixed PHP Warning for empty attributes Pull Request resolved: #3001 Test Plan: npm run test:php Reviewed By: raymon1, mshymon, SayanPandey Differential Revision: D72318247 Pulled By: vinkmeta fbshipit-source-id: 81f6396cc350083643cb887ca2b4f0bec8cc6d55
This was referenced Apr 18, 2025
This was referenced May 2, 2025
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed PHP Warning for empty attributes when selected Google product Category doesn't have any associated attributes. In such cases simply returning the products data without enhancing it.
Type of change
Checklist
Changelog entry
Fixed PHP Warning for empty attributes
Test Plan
npm run test:php