Filtration on All Products page | Synced and Not Synced#2999
Closed
SayanPandey wants to merge 2 commits intofacebook:mainfrom
Closed
Filtration on All Products page | Synced and Not Synced#2999SayanPandey wants to merge 2 commits intofacebook:mainfrom
SayanPandey wants to merge 2 commits intofacebook:mainfrom
Conversation
Contributor
|
@SayanPandey has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
SayanPandey
force-pushed
the
SimplifyingFilters
branch
from
2bbf1cf to
8b61fec
Compare
Contributor
|
@SayanPandey has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
SayanPandey
force-pushed
the
SimplifyingFilters
branch
from
8a3229e to
d1fc582
Compare
Contributor
|
@SayanPandey has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@SayanPandey merged this pull request in 509fd01. |
SayanPandey
added a commit
to SayanPandey/facebook-for-woocommerce
that referenced
this pull request
Apr 8, 2025
Summary: # Filtration on All Products page | Synced and Not Synced ## Description This PR includes the changes of the filtration logic at All Products page 1. We will simplify it by providing 2 options 2. `Synced` will show which facebook items are synced -> both `Sync and show` and `Sync and hide` 3. `Not Synced` will show which are the products that are previously `Do not sync`. ### Type of change - [x] New feature (non-breaking change which adds functionality) ## Checklist - [x] I followed general Pull Request best practices. Meta employees to follow this [wiki]([url](https://fburl.com/wiki/2cgfduwc)) - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have added tests and all the new and existing unit tests pass locally with my changes - [x] I have completed dogfooding and QA testing, or I have conducted thorough due diligence to ensure that it does not break existing functionality. Pull Request resolved: facebook#2999 Test Plan: Follow the steps to test: 1. Make few products 2. Mark some of them `Sync and hide` or `Sync and show` 3. Mark some as `Do not sync` 4. Go to all products page 5. Look for the filter says `Filter by synced to meta` 6. Use it :) ## Screenshots ### Before  ### After  Reviewed By: vinkmeta Differential Revision: D72311890 Pulled By: SayanPandey fbshipit-source-id: d9b41f5df799d3ae9b32e9f9532920660baa2da0
Closed
6 tasks
vinkmeta
pushed a commit
that referenced
this pull request
Apr 13, 2025
Summary: # Filtration on All Products page | Synced and Not Synced ## Description This PR includes the changes of the filtration logic at All Products page 1. We will simplify it by providing 2 options 2. `Synced` will show which facebook items are synced -> both `Sync and show` and `Sync and hide` 3. `Not Synced` will show which are the products that are previously `Do not sync`. ### Type of change - [x] New feature (non-breaking change which adds functionality) ## Checklist - [x] I followed general Pull Request best practices. Meta employees to follow this [wiki]([url](https://fburl.com/wiki/2cgfduwc)) - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have added tests and all the new and existing unit tests pass locally with my changes - [x] I have completed dogfooding and QA testing, or I have conducted thorough due diligence to ensure that it does not break existing functionality. Pull Request resolved: #2999 Test Plan: Follow the steps to test: 1. Make few products 2. Mark some of them `Sync and hide` or `Sync and show` 3. Mark some as `Do not sync` 4. Go to all products page 5. Look for the filter says `Filter by synced to meta` 6. Use it :) ## Screenshots ### Before  ### After  Reviewed By: vinkmeta Differential Revision: D72311890 Pulled By: SayanPandey fbshipit-source-id: d9b41f5df799d3ae9b32e9f9532920660baa2da0
vahidkay-meta
pushed a commit
that referenced
this pull request
Apr 14, 2025
Summary: This PR includes the changes of the filtration logic at All Products page 1. We will simplify it by providing 2 options 2. `Synced` will show which facebook items are synced -> both `Sync and show` and `Sync and hide` 3. `Not Synced` will show which are the products that are previously `Do not sync`. - [x] New feature (non-breaking change which adds functionality) - [x] I followed general Pull Request best practices. Meta employees to follow this [wiki]([url](https://fburl.com/wiki/2cgfduwc)) - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have added tests and all the new and existing unit tests pass locally with my changes - [x] I have completed dogfooding and QA testing, or I have conducted thorough due diligence to ensure that it does not break existing functionality. Pull Request resolved: #2999 Test Plan: Follow the steps to test: 1. Make few products 2. Mark some of them `Sync and hide` or `Sync and show` 3. Mark some as `Do not sync` 4. Go to all products page 5. Look for the filter says `Filter by synced to meta` 6. Use it :)   Reviewed By: vinkmeta Differential Revision: D72311890 Pulled By: SayanPandey fbshipit-source-id: d9b41f5df799d3ae9b32e9f9532920660baa2da0
This was referenced Apr 14, 2025
Closed
mradmeta
pushed a commit
that referenced
this pull request
Apr 14, 2025
Summary: # Filtration on All Products page | Synced and Not Synced ## Description This PR includes the changes of the filtration logic at All Products page 1. We will simplify it by providing 2 options 2. `Synced` will show which facebook items are synced -> both `Sync and show` and `Sync and hide` 3. `Not Synced` will show which are the products that are previously `Do not sync`. ### Type of change - [x] New feature (non-breaking change which adds functionality) ## Checklist - [x] I followed general Pull Request best practices. Meta employees to follow this [wiki]([url](https://fburl.com/wiki/2cgfduwc)) - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have added tests and all the new and existing unit tests pass locally with my changes - [x] I have completed dogfooding and QA testing, or I have conducted thorough due diligence to ensure that it does not break existing functionality. Pull Request resolved: #2999 Test Plan: Follow the steps to test: 1. Make few products 2. Mark some of them `Sync and hide` or `Sync and show` 3. Mark some as `Do not sync` 4. Go to all products page 5. Look for the filter says `Filter by synced to meta` 6. Use it :) ## Screenshots ### Before  ### After  Reviewed By: vinkmeta Differential Revision: D72311890 Pulled By: SayanPandey fbshipit-source-id: d9b41f5df799d3ae9b32e9f9532920660baa2da0
rubycalling
pushed a commit
that referenced
this pull request
Apr 16, 2025
Summary: # Filtration on All Products page | Synced and Not Synced ## Description This PR includes the changes of the filtration logic at All Products page 1. We will simplify it by providing 2 options 2. `Synced` will show which facebook items are synced -> both `Sync and show` and `Sync and hide` 3. `Not Synced` will show which are the products that are previously `Do not sync`. ### Type of change - [x] New feature (non-breaking change which adds functionality) ## Checklist - [x] I followed general Pull Request best practices. Meta employees to follow this [wiki]([url](https://fburl.com/wiki/2cgfduwc)) - [x] I have commented my code, particularly in hard-to-understand areas - [ ] I have added tests and all the new and existing unit tests pass locally with my changes - [x] I have completed dogfooding and QA testing, or I have conducted thorough due diligence to ensure that it does not break existing functionality. Pull Request resolved: #2999 Test Plan: Follow the steps to test: 1. Make few products 2. Mark some of them `Sync and hide` or `Sync and show` 3. Mark some as `Do not sync` 4. Go to all products page 5. Look for the filter says `Filter by synced to meta` 6. Use it :) ## Screenshots ### Before  ### After  Reviewed By: vinkmeta Differential Revision: D72311890 Pulled By: SayanPandey fbshipit-source-id: d9b41f5df799d3ae9b32e9f9532920660baa2da0
Merged
This was referenced Apr 18, 2025
This was referenced May 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Filtration on All Products page | Synced and Not Synced
Description
This PR includes the changes of the filtration logic at All Products page
Syncedwill show which facebook items are synced -> bothSync and showandSync and hideNot Syncedwill show which are the products that are previouslyDo not sync.Type of change
Checklist
Test Plan
Follow the steps to test:
Sync and hideorSync and showDo not syncFilter by synced to metaScreenshots
Before
After