Added external_variant_id to the feed file#2998
Closed
mshymon wants to merge 1 commit intofacebook:mainfrom
Closed
Added external_variant_id to the feed file#2998mshymon wants to merge 1 commit intofacebook:mainfrom
mshymon wants to merge 1 commit intofacebook:mainfrom
Conversation
Contributor
|
@mshymon has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
SayanPandey
pushed a commit
to SayanPandey/facebook-for-woocommerce
that referenced
this pull request
Apr 8, 2025
Summary: ## Description Earlier the external_variant_id (a Woo product ID by value) was added to sync via Batch API. This is a quick follow up to add it to the feed file generation too. ### Type of change Please delete options that are not relevant. - [ ] Bug fix (non-breaking change which fixes an issue) ## Checklist - [ ] I followed general Pull Request best practices. Meta employees to follow this [wiki]([url](https://fburl.com/wiki/2cgfduwc)) - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added tests and all the new and existing unit tests pass locally with my changes - [ ] I have completed dogfooding and QA testing, or I have conducted thorough due diligence to ensure that it does not break existing functionality. ## Changelog entry - Added external_variant_id to the feed file Pull Request resolved: facebook#2998 Test Plan: Tested manually by triggering feed file generation, verified both the generated feed file and there are no feed ingestion errors via Meta internal tooling. Differential Revision: D72305993 Pulled By: mshymon fbshipit-source-id: 6b941d55147e4f7e75a5ee56a4d5d5ca1323c18b
Closed
6 tasks
vahidkay-meta
pushed a commit
that referenced
this pull request
Apr 14, 2025
Summary: ## Description Earlier the external_variant_id (a Woo product ID by value) was added to sync via Batch API. This is a quick follow up to add it to the feed file generation too. ### Type of change Please delete options that are not relevant. - [ ] Bug fix (non-breaking change which fixes an issue) ## Checklist - [ ] I followed general Pull Request best practices. Meta employees to follow this [wiki]([url](https://fburl.com/wiki/2cgfduwc)) - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added tests and all the new and existing unit tests pass locally with my changes - [ ] I have completed dogfooding and QA testing, or I have conducted thorough due diligence to ensure that it does not break existing functionality. ## Changelog entry - Added external_variant_id to the feed file Pull Request resolved: #2998 Test Plan: Tested manually by triggering feed file generation, verified both the generated feed file and there are no feed ingestion errors via Meta internal tooling. Differential Revision: D72305993 Pulled By: mshymon fbshipit-source-id: 6b941d55147e4f7e75a5ee56a4d5d5ca1323c18b
vahidkay-meta
pushed a commit
that referenced
this pull request
Apr 14, 2025
Summary: ## Description Earlier the external_variant_id (a Woo product ID by value) was added to sync via Batch API. This is a quick follow up to add it to the feed file generation too. ### Type of change Please delete options that are not relevant. - [ ] Bug fix (non-breaking change which fixes an issue) ## Checklist - [ ] I followed general Pull Request best practices. Meta employees to follow this [wiki]([url](https://fburl.com/wiki/2cgfduwc)) - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added tests and all the new and existing unit tests pass locally with my changes - [ ] I have completed dogfooding and QA testing, or I have conducted thorough due diligence to ensure that it does not break existing functionality. ## Changelog entry - Added external_variant_id to the feed file Pull Request resolved: #2998 Test Plan: Tested manually by triggering feed file generation, verified both the generated feed file and there are no feed ingestion errors via Meta internal tooling. Differential Revision: D72305993 Pulled By: mshymon fbshipit-source-id: 6b941d55147e4f7e75a5ee56a4d5d5ca1323c18b
This was referenced Apr 14, 2025
Closed
mradmeta
pushed a commit
that referenced
this pull request
Apr 14, 2025
Summary: ## Description Earlier the external_variant_id (a Woo product ID by value) was added to sync via Batch API. This is a quick follow up to add it to the feed file generation too. ### Type of change Please delete options that are not relevant. - [ ] Bug fix (non-breaking change which fixes an issue) ## Checklist - [ ] I followed general Pull Request best practices. Meta employees to follow this [wiki]([url](https://fburl.com/wiki/2cgfduwc)) - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added tests and all the new and existing unit tests pass locally with my changes - [ ] I have completed dogfooding and QA testing, or I have conducted thorough due diligence to ensure that it does not break existing functionality. ## Changelog entry - Added external_variant_id to the feed file Pull Request resolved: #2998 Test Plan: Tested manually by triggering feed file generation, verified both the generated feed file and there are no feed ingestion errors via Meta internal tooling. Differential Revision: D72305993 Pulled By: mshymon fbshipit-source-id: 6b941d55147e4f7e75a5ee56a4d5d5ca1323c18b
rubycalling
pushed a commit
that referenced
this pull request
Apr 16, 2025
Summary: ## Description Earlier the external_variant_id (a Woo product ID by value) was added to sync via Batch API. This is a quick follow up to add it to the feed file generation too. ### Type of change Please delete options that are not relevant. - [ ] Bug fix (non-breaking change which fixes an issue) ## Checklist - [ ] I followed general Pull Request best practices. Meta employees to follow this [wiki]([url](https://fburl.com/wiki/2cgfduwc)) - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added tests and all the new and existing unit tests pass locally with my changes - [ ] I have completed dogfooding and QA testing, or I have conducted thorough due diligence to ensure that it does not break existing functionality. ## Changelog entry - Added external_variant_id to the feed file Pull Request resolved: #2998 Test Plan: Tested manually by triggering feed file generation, verified both the generated feed file and there are no feed ingestion errors via Meta internal tooling. Differential Revision: D72305993 Pulled By: mshymon fbshipit-source-id: 6b941d55147e4f7e75a5ee56a4d5d5ca1323c18b
Merged
This was referenced Apr 18, 2025
This was referenced May 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Earlier the external_variant_id (a Woo product ID by value) was added to sync via Batch API. This is a quick follow up to add it to the feed file generation too.
Type of change
Please delete options that are not relevant.
Checklist
Changelog entry
Test Plan
Tested manually by triggering feed file generation, verified both the generated feed file and there are no feed ingestion errors via Meta internal tooling.