Relocating bulk actions by SayanPandey · Pull Request #2943 · facebook/facebook-for-woocommerce

SayanPandey · 2025-03-13T18:39:04Z

Product Sync controls - Relocating Bulk sync controls to a Edit panel

Relocating the bulk facebook sync options to edit panel
Removal of bulk sync controls form the panel.

Screenshots:

Before:

After:

Detailed test instructions:

Create few products in WooCommerce
Go to the products tab and make some products
Now select multiple products and click on edit in bulk options dropdown
Click apply
Edit panel should open
On the right observe Facebook Sync dropdown
Select your choice
Now click Blue update button

facebook-github-bot · 2025-03-13T18:40:12Z

@SayanPandey has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot · 2025-03-14T11:19:39Z

@SayanPandey has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot · 2025-03-14T11:20:24Z

@SayanPandey has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot · 2025-03-14T11:34:09Z

@SayanPandey has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot · 2025-03-14T11:34:46Z

@SayanPandey has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot · 2025-03-14T15:26:24Z

@SayanPandey has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot · 2025-03-14T15:27:32Z

@SayanPandey has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot · 2025-03-14T15:29:42Z

@SayanPandey has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot · 2025-03-14T15:30:33Z

@SayanPandey has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot · 2025-03-17T15:07:08Z

@SayanPandey has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot · 2025-03-19T15:49:35Z

@SayanPandey has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot · 2025-03-19T15:51:02Z

@SayanPandey has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot · 2025-04-01T15:07:35Z

@SayanPandey has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot · 2025-04-01T15:12:34Z

@SayanPandey has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot · 2025-04-02T13:31:43Z

@SayanPandey has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot · 2025-04-03T16:31:37Z

@SayanPandey has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot · 2025-04-04T15:36:29Z

@SayanPandey merged this pull request in 427510e.

Summary: Relocating the bulk facebook sync options to edit panel Removal of bulk sync controls form the panel. ![image](https://github.com/user-attachments/assets/e995e52f-0a7a-44d2-ab1c-4d19f3fc9ab5) ![image](https://github.com/user-attachments/assets/ce1a3d25-1294-4072-be10-4d9a4946a5c1) ![image](https://github.com/user-attachments/assets/bf2e3101-f0dd-490f-9cbe-9a1c98c42607) 1. Create few products in WooCommerce 2. Go to the products tab and make some products 3. Now select multiple products and click on edit in bulk options dropdown 4. Click apply 5. Edit panel should open 6. On the right observe Facebook Sync dropdown 7. Select your choice 8. Now click Blue update button Pull Request resolved: #2943 Reviewed By: vinkmeta Differential Revision: D71134957 Pulled By: SayanPandey fbshipit-source-id: 7adf6b86a55108b78dd23407b616908bc074ce87

Summary: ### Product Sync controls - Relocating Bulk sync controls to a Edit panel Relocating the bulk facebook sync options to edit panel Removal of bulk sync controls form the panel. ### Screenshots: #### Before: ![image](https://github.com/user-attachments/assets/e995e52f-0a7a-44d2-ab1c-4d19f3fc9ab5) #### After: ![image](https://github.com/user-attachments/assets/ce1a3d25-1294-4072-be10-4d9a4946a5c1) ![image](https://github.com/user-attachments/assets/bf2e3101-f0dd-490f-9cbe-9a1c98c42607) ### Detailed test instructions: 1. Create few products in WooCommerce 2. Go to the products tab and make some products 3. Now select multiple products and click on edit in bulk options dropdown 4. Click apply 5. Edit panel should open 6. On the right observe Facebook Sync dropdown 7. Select your choice 8. Now click Blue update button Pull Request resolved: #2943 Reviewed By: vinkmeta Differential Revision: D71134957 Pulled By: SayanPandey fbshipit-source-id: 7adf6b86a55108b78dd23407b616908bc074ce87

facebook-github-bot added the CLA Signed label Mar 13, 2025

SayanPandey force-pushed the RelocatingBulkActions branch from 20215f3 to cc4b77c Compare March 17, 2025 15:06

SayanPandey added 6 commits April 1, 2025 16:01

Relocating Bulk sync mode

94d812d

Adding updated strings from figma

48d8689

Fixing lint issues

57b5174

Adding delete on Do no sync

1fb8fab

Removing lint whitespace

83a294f

Fixing tests

b978a45

SayanPandey force-pushed the RelocatingBulkActions branch from c4c98ef to b978a45 Compare April 1, 2025 15:04

Fixing typo

eeb211b

Providng better names for the flags

65f838a

Fixing Diff comments

1ccded0

facebook-github-bot closed this in 427510e Apr 4, 2025

facebook-github-bot added the Merged label Apr 4, 2025

sol-loup mentioned this pull request Apr 10, 2025

Creating PHPUnit Test Trait to safely update and restore option values with update_option #3043

Closed

6 tasks

This was referenced Apr 14, 2025

Unit test trait to allow options to be globally set in isolation between tests #3057

Closed

fix skipped tests2 #3058

Closed

tzahgr mentioned this pull request Apr 17, 2025

Release/3.4.7 #3064

Merged

This was referenced May 2, 2025

[LINTFIX] Fixes for AdminNoticeHandler.php #3131

Closed

[LINTFIX] Fixes for Dependencies.php #3132

Closed

[LINTFIX] Fixes for Compatibility.php #3133

Closed

Conversation

SayanPandey commented Mar 13, 2025

Product Sync controls - Relocating Bulk sync controls to a Edit panel

Screenshots:

Before:

After:

Detailed test instructions:

Uh oh!

facebook-github-bot commented Mar 13, 2025

Uh oh!

facebook-github-bot commented Mar 14, 2025

Uh oh!

facebook-github-bot commented Mar 14, 2025

Uh oh!

facebook-github-bot commented Mar 14, 2025

Uh oh!

facebook-github-bot commented Mar 14, 2025

Uh oh!

facebook-github-bot commented Mar 14, 2025

Uh oh!

facebook-github-bot commented Mar 14, 2025

Uh oh!

facebook-github-bot commented Mar 14, 2025

Uh oh!

facebook-github-bot commented Mar 14, 2025

Uh oh!

facebook-github-bot commented Mar 17, 2025

Uh oh!

facebook-github-bot commented Mar 19, 2025

Uh oh!

facebook-github-bot commented Mar 19, 2025

Uh oh!

facebook-github-bot commented Apr 1, 2025

Uh oh!

facebook-github-bot commented Apr 1, 2025

Uh oh!

facebook-github-bot commented Apr 2, 2025

Uh oh!

facebook-github-bot commented Apr 3, 2025

Uh oh!

facebook-github-bot commented Apr 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants