config: message relayer by tynes · Pull Request #809 · ethereum-optimism/optimism

tynes · 2021-05-07T19:58:35Z

Description
This updates the config parsing for the message relayer in a backwards compatible way. bcfg is used which parses both from the command line (argv) and from environment variables. The env vars it looks for are based on the prefix MESSAGE_RELAYER_<name of variable. This PR is intentionally backwards compatible until we can update all config throughout the repo

changeset-bot · 2021-05-07T19:58:38Z

🦋 Changeset detected

Latest commit: 1e93a6a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@eth-optimism/message-relayer	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov-commenter · 2021-05-07T20:44:56Z

Codecov Report

Merging #809 (1e93a6a) into master (d723b2a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #809   +/-   ##
=======================================
  Coverage   82.21%   82.21%           
=======================================
  Files          48       48           
  Lines        1895     1895           
  Branches      303      303           
=======================================
  Hits         1558     1558           
  Misses        337      337

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d723b2a...1e93a6a. Read the comment docs.

tynes · 2021-05-07T23:24:02Z

packages/message-relayer/src/exec/run.ts

@@ -69,11 +96,17 @@ const main = async () => {
    l2RpcProvider: l2Provider,
    addressManagerAddress: ADDRESS_MANAGER_ADDRESS,
    l1Wallet: wallet,


Once we update all of the deploy config then we can remove the backwards compatible requirement and this will clean up this file a ton

I've cleaned up this part of the codebase, was able to remove the ts-ignore lines

* relayer: migrate towards prefixed config w/ backwards compat * chore: update relayer config parsing * env: use start-offset instead of block offset * lint: fix * deps: add bcfg * message-relayer: cleaner config parsing * lint: fix

* docs: add truffle example * fix: add gasPrice: 0 to all ctc calls and deploys * chore(truffle-example): use correct truffle command * fix: install missing packages * style: fix missing newlines * fix: attempt to fix yarn.lock (2) * Update integration.yml * specify truffle config and network * correctly specify path and version * relayer: logging cleanup (#807) * relayer: don't log options at startup * chore: add changeset * relayer: log specifc config options * config: message relayer (#809) * relayer: migrate towards prefixed config w/ backwards compat * chore: update relayer config parsing * env: use start-offset instead of block offset * lint: fix * deps: add bcfg * message-relayer: cleaner config parsing * lint: fix * Version Packages (#833) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * fix: geth miner timestamp bug (#836) * l2geth: use correct timestamp protection * chore: add changeset * Version Packages (#837) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * style: require curly braces for if statements (#835) * test[integration-tests]: l2geth call and creation OOG (#839) * fix: WE DID IT Co-authored-by: Georgios Konstantopoulos <me@gakonst.com> Co-authored-by: Kelvin Fichter <kelvinfichter@gmail.com> Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: ben-chain <ben@pseudonym.party>

* relayer: migrate towards prefixed config w/ backwards compat * chore: update relayer config parsing * env: use start-offset instead of block offset * lint: fix * deps: add bcfg * message-relayer: cleaner config parsing * lint: fix

* docs: add truffle example * fix: add gasPrice: 0 to all ctc calls and deploys * chore(truffle-example): use correct truffle command * fix: install missing packages * style: fix missing newlines * fix: attempt to fix yarn.lock (2) * Update integration.yml * specify truffle config and network * correctly specify path and version * relayer: logging cleanup (ethereum-optimism#807) * relayer: don't log options at startup * chore: add changeset * relayer: log specifc config options * config: message relayer (ethereum-optimism#809) * relayer: migrate towards prefixed config w/ backwards compat * chore: update relayer config parsing * env: use start-offset instead of block offset * lint: fix * deps: add bcfg * message-relayer: cleaner config parsing * lint: fix * Version Packages (ethereum-optimism#833) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * fix: geth miner timestamp bug (ethereum-optimism#836) * l2geth: use correct timestamp protection * chore: add changeset * Version Packages (ethereum-optimism#837) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * style: require curly braces for if statements (ethereum-optimism#835) * test[integration-tests]: l2geth call and creation OOG (ethereum-optimism#839) * fix: WE DID IT Co-authored-by: Georgios Konstantopoulos <me@gakonst.com> Co-authored-by: Kelvin Fichter <kelvinfichter@gmail.com> Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: ben-chain <ben@pseudonym.party>

…data (#809)

* fix: set fdg and pdg implementations to non-zero address on v2 codepath (#806) * fix: set fault and permission games implementations to non-zero address on v2 codepath * chore: make faultDisputeGame 0 on DeployOPChain * chore: remove unused import, just pr passing (#809)

tynes added 2 commits May 7, 2021 12:55

relayer: migrate towards prefixed config w/ backwards compat

ffbe999

chore: update relayer config parsing

b246295

tynes requested a review from K-Ho as a code owner May 7, 2021 19:58

env: use start-offset instead of block offset

2948c31

tynes added 2 commits May 7, 2021 13:51

lint: fix

abd10f0

deps: add bcfg

7229ac8

tynes commented May 7, 2021

View reviewed changes

smartcontracts approved these changes May 7, 2021

View reviewed changes

smartcontracts added the A-ts-packages label May 7, 2021

tynes added 3 commits May 9, 2021 12:46

message-relayer: cleaner config parsing

6e11c13

lint: fix

2482b22

Merge branch 'master' into config/message-relayer

1e93a6a

tynes merged commit aedf931 into master May 10, 2021

tynes deleted the config/message-relayer branch May 10, 2021 22:55

theochap pushed a commit that referenced this pull request Dec 10, 2025

docs: update providers.md to use new next method instead of old open_…

90552f1

…data (#809)

OptimismBot pushed a commit that referenced this pull request Jan 21, 2026

chore: remove unused import, just pr passing (#809)

0312831

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

config: message relayer#809

config: message relayer#809
tynes merged 8 commits intomasterfrom
config/message-relayer

tynes commented May 7, 2021

Uh oh!

changeset-bot bot commented May 7, 2021 •

edited

Loading

Uh oh!

codecov-commenter commented May 7, 2021 •

edited

Loading

Uh oh!

tynes May 7, 2021

Uh oh!

tynes May 9, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

Conversation

tynes commented May 7, 2021

Uh oh!

changeset-bot bot commented May 7, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

codecov-commenter commented May 7, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

tynes May 7, 2021

Choose a reason for hiding this comment

Uh oh!

tynes May 9, 2021

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

changeset-bot bot commented May 7, 2021 •

edited

Loading

codecov-commenter commented May 7, 2021 •

edited

Loading