Conversation
🦋 Changeset detectedLatest commit: f8d245e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
smartcontracts
pushed a commit
that referenced
this pull request
May 11, 2021
* l2geth: use correct timestamp protection * chore: add changeset
smartcontracts
added a commit
that referenced
this pull request
May 12, 2021
* docs: add truffle example * fix: add gasPrice: 0 to all ctc calls and deploys * chore(truffle-example): use correct truffle command * fix: install missing packages * style: fix missing newlines * fix: attempt to fix yarn.lock (2) * Update integration.yml * specify truffle config and network * correctly specify path and version * relayer: logging cleanup (#807) * relayer: don't log options at startup * chore: add changeset * relayer: log specifc config options * config: message relayer (#809) * relayer: migrate towards prefixed config w/ backwards compat * chore: update relayer config parsing * env: use start-offset instead of block offset * lint: fix * deps: add bcfg * message-relayer: cleaner config parsing * lint: fix * Version Packages (#833) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * fix: geth miner timestamp bug (#836) * l2geth: use correct timestamp protection * chore: add changeset * Version Packages (#837) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * style: require curly braces for if statements (#835) * test[integration-tests]: l2geth call and creation OOG (#839) * fix: WE DID IT Co-authored-by: Georgios Konstantopoulos <me@gakonst.com> Co-authored-by: Kelvin Fichter <kelvinfichter@gmail.com> Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: ben-chain <ben@pseudonym.party>
InoMurko
pushed a commit
to omgnetwork/optimism
that referenced
this pull request
May 25, 2021
* l2geth: use correct timestamp protection * chore: add changeset
InoMurko
pushed a commit
to omgnetwork/optimism
that referenced
this pull request
May 25, 2021
* docs: add truffle example * fix: add gasPrice: 0 to all ctc calls and deploys * chore(truffle-example): use correct truffle command * fix: install missing packages * style: fix missing newlines * fix: attempt to fix yarn.lock (2) * Update integration.yml * specify truffle config and network * correctly specify path and version * relayer: logging cleanup (ethereum-optimism#807) * relayer: don't log options at startup * chore: add changeset * relayer: log specifc config options * config: message relayer (ethereum-optimism#809) * relayer: migrate towards prefixed config w/ backwards compat * chore: update relayer config parsing * env: use start-offset instead of block offset * lint: fix * deps: add bcfg * message-relayer: cleaner config parsing * lint: fix * Version Packages (ethereum-optimism#833) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * fix: geth miner timestamp bug (ethereum-optimism#836) * l2geth: use correct timestamp protection * chore: add changeset * Version Packages (ethereum-optimism#837) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * style: require curly braces for if statements (ethereum-optimism#835) * test[integration-tests]: l2geth call and creation OOG (ethereum-optimism#839) * fix: WE DID IT Co-authored-by: Georgios Konstantopoulos <me@gakonst.com> Co-authored-by: Kelvin Fichter <kelvinfichter@gmail.com> Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: ben-chain <ben@pseudonym.party>
theochap
pushed a commit
that referenced
this pull request
Dec 10, 2025
* feat(workspace): Isolate FPVM-specific platform code * rebase * lint * feat(host): Run client program natively in process (#836) * feat(host): Run client program natively * lint * rebase * fix * monorepo update * lint
OptimismBot
pushed a commit
that referenced
this pull request
Feb 6, 2026
…lag (#836) * refactor: replace create2 deployer for arachnid * feat: add ConditionalDeployer as predeploy and add L2CM dev flag * fix: add pre-pr fix * fix: remove unnecessary auth in conditional deployer * feat: add custom error for deployment revert * test: add l2cm e2e apply test case
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 13, 2026
* feat: add ConditionalDeployer (#687) * feat: refactor l2cm conditional deployer predeploy and add L2CM dev flag (#836) * refactor: replace create2 deployer for arachnid * feat: add ConditionalDeployer as predeploy and add L2CM dev flag * fix: add pre-pr fix * fix: remove unnecessary auth in conditional deployer * feat: add custom error for deployment revert * test: add l2cm e2e apply test case * fix: conditional deployer tests and match style guide * fix: remove fork test * feat: add common test to cond deployer test * fix: follow constant style guide * fix: comments and add msg.value to ConditionalDeployer * fix: conditional deployer comment in apply test * fix: arachnid reference comment * fix: add msg.value to conditional deployer * fix: deterministic deployment proxy comment * fix: add code length check after deploy * fix: add code length check after deploy * fix: pre pr fix * refactor: remove useL2CM bool initialization * fix: make deploy non payable and add tests * fix: make deploy non payable * test: add missing getters test * fix: add missing natspec * feat: add todo issue for devfeatures cyclic import * chore: pre pr run * refactor: add returned address check in deploy * fix: use encodePacked for return address test * fix: unify getters in a single test contract * fix: variables naming and mutability * fix: remove underscore from local variable * fix: remove address payable from deterministicDeploymentProxy * refactor: rename dummy storage variable in test and add internal getExpectedImplementation helper --------- Co-authored-by: niha <205694301+0xniha@users.noreply.github.com> Co-authored-by: OneTony <onetony@defi.sucks> Co-authored-by: 0xOneTony <112496816+0xOneTony@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug in the prevent monotonicity logic where the updated timestamp is not used. The old code updated the
L1Timestampon the transaction struct but didn't pass it along to the block header. The timestamp for evm execution is pulled from the block timestamp. This will prevent the same bug from happening again