style: require curly braces for if statements#835
Merged
smartcontracts merged 1 commit intomasterfrom May 11, 2021
Merged
Conversation
|
smartcontracts
added
C-chore
Contributor
Author
|
I am prepared to die on this hill |
smartcontracts
added a commit
that referenced
this pull request
May 11, 2021
smartcontracts
added a commit
that referenced
this pull request
May 12, 2021
* docs: add truffle example * fix: add gasPrice: 0 to all ctc calls and deploys * chore(truffle-example): use correct truffle command * fix: install missing packages * style: fix missing newlines * fix: attempt to fix yarn.lock (2) * Update integration.yml * specify truffle config and network * correctly specify path and version * relayer: logging cleanup (#807) * relayer: don't log options at startup * chore: add changeset * relayer: log specifc config options * config: message relayer (#809) * relayer: migrate towards prefixed config w/ backwards compat * chore: update relayer config parsing * env: use start-offset instead of block offset * lint: fix * deps: add bcfg * message-relayer: cleaner config parsing * lint: fix * Version Packages (#833) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * fix: geth miner timestamp bug (#836) * l2geth: use correct timestamp protection * chore: add changeset * Version Packages (#837) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * style: require curly braces for if statements (#835) * test[integration-tests]: l2geth call and creation OOG (#839) * fix: WE DID IT Co-authored-by: Georgios Konstantopoulos <me@gakonst.com> Co-authored-by: Kelvin Fichter <kelvinfichter@gmail.com> Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: ben-chain <ben@pseudonym.party>
InoMurko
pushed a commit
to omgnetwork/optimism
that referenced
this pull request
May 25, 2021
InoMurko
pushed a commit
to omgnetwork/optimism
that referenced
this pull request
May 25, 2021
* docs: add truffle example * fix: add gasPrice: 0 to all ctc calls and deploys * chore(truffle-example): use correct truffle command * fix: install missing packages * style: fix missing newlines * fix: attempt to fix yarn.lock (2) * Update integration.yml * specify truffle config and network * correctly specify path and version * relayer: logging cleanup (ethereum-optimism#807) * relayer: don't log options at startup * chore: add changeset * relayer: log specifc config options * config: message relayer (ethereum-optimism#809) * relayer: migrate towards prefixed config w/ backwards compat * chore: update relayer config parsing * env: use start-offset instead of block offset * lint: fix * deps: add bcfg * message-relayer: cleaner config parsing * lint: fix * Version Packages (ethereum-optimism#833) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * fix: geth miner timestamp bug (ethereum-optimism#836) * l2geth: use correct timestamp protection * chore: add changeset * Version Packages (ethereum-optimism#837) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * style: require curly braces for if statements (ethereum-optimism#835) * test[integration-tests]: l2geth call and creation OOG (ethereum-optimism#839) * fix: WE DID IT Co-authored-by: Georgios Konstantopoulos <me@gakonst.com> Co-authored-by: Kelvin Fichter <kelvinfichter@gmail.com> Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: ben-chain <ben@pseudonym.party>
OptimismBot
pushed a commit
that referenced
this pull request
Feb 3, 2026
…#835) * fix: only allow permissioned game types in opcmv2 deployment * docs: add comment for permissionless games config in deployopchain * feat: add isInitialDeployment argument to std validator script
smartcontracts
pushed a commit
that referenced
this pull request
Feb 3, 2026
…#835) * fix: only allow permissioned game types in opcmv2 deployment * docs: add comment for permissionless games config in deployopchain * feat: add isInitialDeployment argument to std validator script
smartcontracts
pushed a commit
that referenced
this pull request
Feb 5, 2026
…#835) * fix: only allow permissioned game types in opcmv2 deployment * docs: add comment for permissionless games config in deployopchain * feat: add isInitialDeployment argument to std validator script
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 6, 2026
#19077) * fix: only allow enabling permissioned game types in opcmv2 deployment (#835) * fix: only allow permissioned game types in opcmv2 deployment * docs: add comment for permissionless games config in deployopchain * feat: add isInitialDeployment argument to std validator script * fix: undo OPCMv1 changes * fix: old test content * fix: expect validator errors for disabled games in deploy test CANNON and CANNON_KONA are intentionally disabled during initial deployment, so no implementations are registered. The validator correctly flags this as PLDG-10 and CKDG-10 errors. Update test to expect these errors. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> * fix: revert on non-PERMISSIONED_CANNON game type in DeployOPChain Address review feedback: raise an error instead of silently overwriting the disputeGameType input. Only PERMISSIONED_CANNON is valid for initial deployment since no prestate exists for permissionless games. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: niha <205694301+0xniha@users.noreply.github.com> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates
tslint.base.jsonto require thatifstatements use curly braces. Also lints files to pass that check.