Conversation
tynes
requested review from
ben-chain,
maurelian and
smartcontracts
as code owners
🦋 Changeset detectedLatest commit: ec74a21 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
snario
suggested changes
Apr 26, 2021
Contributor
snario
left a comment
snario
left a comment
There was a problem hiding this comment.
We can maintain the concurrency
snario
reviewed
Apr 26, 2021
Comment on lines
+1
to
+5
| --- | ||
| "@eth-optimism/contracts": patch | ||
| --- | ||
|
|
||
| Updates the `yarn build` command to not error |
Contributor
There was a problem hiding this comment.
I think we do not need a changeset since yarn build is only needed locally? Perhaps to bump the Docker image's construction? If so that makes sense.
Co-authored-by: Liam Horne <liam@lihorne.com>
snario
approved these changes
Apr 27, 2021
maurelian
pushed a commit
that referenced
this pull request
Apr 29, 2021
* contracts: fix build script * chore: add changeset * Update packages/contracts/scripts/build.sh Co-authored-by: Liam Horne <liam@lihorne.com> * build: parallel Co-authored-by: Liam Horne <liam@lihorne.com>
InoMurko
pushed a commit
to omgnetwork/optimism
that referenced
this pull request
May 25, 2021
* contracts: fix build script * chore: add changeset * Update packages/contracts/scripts/build.sh Co-authored-by: Liam Horne <liam@lihorne.com> * build: parallel Co-authored-by: Liam Horne <liam@lihorne.com>
theochap
pushed a commit
that referenced
this pull request
Dec 10, 2025
* feat(derive): pipeline core * fix(derive): kona providers test utils * fix(derive): test-utils
emhane
pushed a commit
that referenced
this pull request
Feb 4, 2026
Closes #641 --------- Co-authored-by: Himess <semihcvlk53@gmail.com>
emhane
pushed a commit
that referenced
this pull request
Feb 4, 2026
Closes #641 --------- Co-authored-by: Himess <semihcvlk53@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the script that is called during
yarn buildyarn run build:typescript:ovmwhich does not existset -eto fail script execution if any commands exit with non-zero exit code