Skip to content

docs: add hardhat example + ci#641

Merged
gakonst merged 7 commits intomasterfrom
ci/optimism-tutorial
Apr 28, 2021
Merged

docs: add hardhat example + ci#641
gakonst merged 7 commits intomasterfrom
ci/optimism-tutorial

Conversation

@platocrat
Copy link
Contributor

Description
Replaces #501 with a single PR for the optimism-tutorial.
Additional PRs to follow for the following repositories:

  1. Waffle-ERC20-Example
  2. Truffle-ERC20-Example
  3. l1-l2-deposit-withdrawal

@changeset-bot
Copy link

changeset-bot bot commented Apr 26, 2021

🦋 Changeset detected

Latest commit: 1a8f5e9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@eth-optimism/hardhat-ovm Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@platocrat platocrat changed the title Ci/optimism tutorial ci: optimism-tutorial Apr 26, 2021
@platocrat platocrat changed the title ci: optimism-tutorial ci: add optimism-tutorial Apr 26, 2021
@gakonst gakonst force-pushed the ci/optimism-tutorial branch from 5919361 to 81e4aa1 Compare April 27, 2021 10:47
@gakonst
Copy link
Contributor

gakonst commented Apr 27, 2021

Changed the following:

  • now using the updated hardhat-ovm package, so that tests run fast (ie w/o waiting the 4s time).
  • removed hardcoded gaslimits/gasprices
  • renamed the package to hardhat-example (better than calling it "optimism tutorial", too generic), since it'll be in line with the rest of the examples (waffle and truffle).
  • removed the weird if/else expect checks and correctly using reverted. Of note: once the EM propagates errors up, we should also check the revert messages.
  • removed no longer necessary chai-as-promised deps

@gakonst gakonst force-pushed the ci/optimism-tutorial branch from 81e4aa1 to 9005344 Compare April 27, 2021 11:17
@gakonst gakonst changed the title ci: add optimism-tutorial docs: add hardhat example Apr 27, 2021
@gakonst gakonst changed the title docs: add hardhat example docs: add hardhat example + ci Apr 27, 2021
@gakonst gakonst changed the base branch from master to feat/hh-interval April 27, 2021 11:21
@gakonst gakonst force-pushed the ci/optimism-tutorial branch from 9005344 to 5ec6c6d Compare April 27, 2021 11:50
@gakonst gakonst removed the request for review from smartcontracts April 27, 2021 18:12
@gakonst gakonst marked this pull request as draft April 27, 2021 18:12
@gakonst
Copy link
Contributor

gakonst commented Apr 27, 2021

Converted to draft, to merge after figuring out the bug in #646.

gakonst and others added 3 commits April 28, 2021 13:32
…ider and its signers

The default is 50ms, which should make running the OVM tests smooth. If you want
to run tests against a remote node and do not want to overwhelm it, set the
parameter in the hardhat config's network
@gakonst gakonst force-pushed the ci/optimism-tutorial branch from 5ec6c6d to 709317b Compare April 28, 2021 10:34
@gakonst gakonst marked this pull request as ready for review April 28, 2021 10:34
@gakonst gakonst changed the base branch from feat/hh-interval to master April 28, 2021 10:34
gakonst added 3 commits April 28, 2021 14:53
workaround hardhat not generating build artifacts for both evm and ovm
this post state is not giving us much info, and it's hard to
update it or debug it when it does not pass for any reason
@gakonst gakonst force-pushed the ci/optimism-tutorial branch from 6ea21b7 to 1a8f5e9 Compare April 28, 2021 12:34
@gakonst gakonst merged commit 122df8c into master Apr 28, 2021
@gakonst gakonst deleted the ci/optimism-tutorial branch April 28, 2021 12:49
InoMurko pushed a commit to omgnetwork/optimism that referenced this pull request May 25, 2021
* feat(hardhat-ovm): allow overriding the polling interval for the provider and its signers

The default is 50ms, which should make running the OVM tests smooth. If you want
to run tests against a remote node and do not want to overwhelm it, set the
parameter in the hardhat config's network

* chore: add changeset

* docs: add hardhat example

imported from https://github.com/ethereum-optimism/optimism-tutorial/

* ci: add deploy/deploy:ovm

* fix(contracts): wait for contracts to finish

workaround hardhat not generating build artifacts for both evm and ovm

* fix: use istanbul hard fork

* test(contracts): remove hardcoded post-state in nuisance gas test

this post state is not giving us much info, and it's hard to
update it or debug it when it does not pass for any reason

Co-authored-by: Georgios Konstantopoulos <me@gakonst.com>
emhane pushed a commit that referenced this pull request Feb 4, 2026
Closes #641

---------

Co-authored-by: Himess <semihcvlk53@gmail.com>
emhane pushed a commit that referenced this pull request Feb 4, 2026
Closes #641

---------

Co-authored-by: Himess <semihcvlk53@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments