Skip to content

contracts: fix build script #642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
snario merged 4 commits into from
Apr 27, 2021
Merged

contracts: fix build script #642

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1fb0f99
contracts: fix build script
tynes Apr 26, 2021
8a9c45f
chore: add changeset
tynes Apr 26, 2021
da67e5a
Update packages/contracts/scripts/build.sh
tynes Apr 27, 2021
ec74a21
build: parallel
tynes Apr 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/two-houses-work.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@eth-optimism/contracts": patch
---

Updates the `yarn build` command to not error
Comment on lines +1 to +5

@snario snario Apr 26, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we do not need a changeset since yarn build is only needed locally? Perhaps to bump the Docker image's construction? If so that makes sense.

10 changes: 8 additions & 2 deletions packages/contracts/scripts/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,8 @@
yarn run build:typescript & yarn run build:contracts
yarn run build:typescript:ovm & yarn run build:contracts:ovm
#!/bin/bash

set -e

yarn run build:typescript&
yarn run build:contracts&
yarn run build:contracts:ovm&
wait