fix(contracts): do not build ovm and contracts concurrently#650
Merged
fix(contracts): do not build ovm and contracts concurrently#650
Conversation
there's a race condition somewhere in hardhat which does not generate the artifacts in the correct directory sometimes, causing our tests to fail with 'artifact not found'
gakonst
requested review from
ben-chain,
maurelian and
smartcontracts
as code owners
|
InoMurko
pushed a commit
to omgnetwork/optimism
that referenced
this pull request
May 25, 2021
…-optimism#650) there's a race condition somewhere in hardhat which does not generate the artifacts in the correct directory sometimes, causing our tests to fail with 'artifact not found'
theochap
pushed a commit
that referenced
this pull request
Dec 10, 2025
* chore(executor): test executor utils * fix: remove gas lim tests
emhane
added a commit
that referenced
this pull request
Feb 4, 2026
This PR added support to run op-reth in sequencer and op-reth(with proof) in validator for the e2e test. Note: In this setup pruning test isn't supported(at this moment) since this test is falling outside the proof window of reth. --------- Co-authored-by: Emilia Hane <elsaemiliaevahane@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
emhane
added a commit
that referenced
this pull request
Feb 4, 2026
This PR added support to run op-reth in sequencer and op-reth(with proof) in validator for the e2e test. Note: In this setup pruning test isn't supported(at this moment) since this test is falling outside the proof window of reth. --------- Co-authored-by: Emilia Hane <elsaemiliaevahane@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
emhane
added a commit
that referenced
this pull request
Feb 4, 2026
This PR added support to run op-reth in sequencer and op-reth(with proof) in validator for the e2e test. Note: In this setup pruning test isn't supported(at this moment) since this test is falling outside the proof window of reth. --------- Co-authored-by: Emilia Hane <elsaemiliaevahane@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
emhane
added a commit
that referenced
this pull request
Feb 4, 2026
This PR added support to run op-reth in sequencer and op-reth(with proof) in validator for the e2e test. Note: In this setup pruning test isn't supported(at this moment) since this test is falling outside the proof window of reth. --------- Co-authored-by: Emilia Hane <elsaemiliaevahane@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
there's a race condition somewhere in hardhat which does not generate the artifacts
in the correct directory sometimes, causing our tests to fail with 'artifact not found'
This issue was introduced in #642