Support multiple transactions in batch submitter#1993
Support multiple transactions in batch submitter#1993mslipper merged 8 commits intoethereum-optimism:developfrom
Conversation
mslipper
commented
Jan 7, 2022
mslipper
commented
- feat: add telemetry to go batch-submitter
- feat: cache go BSS txn serialization
- chore: prepare for iterative batch-tx size reduction
- feat: submit multiple sequencer txs per batch
- Code review updates
This commit places the batch sequencer tx size check inside of a for loop so that the we can continue to whittle away batch tx sizes until satisfying the configured maximum. This doesn't result in a behavioral change, as the for loop exits after the first iteration. This is done to make the behavioral changes more apparent in subsequent commits.
|
Codecov Report
@@ Coverage Diff @@
## develop #1993 +/- ##
========================================
Coverage 74.58% 74.58%
========================================
Files 79 79
Lines 2554 2554
Branches 401 401
========================================
Hits 1905 1905
Misses 649 649
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
| oldLen := len(batchElements) | ||
| newBatchElementsLen := (oldLen * 9) / 10 | ||
| batchElements = batchElements[:newBatchElementsLen] | ||
| log.Info("pruned batch", "old_num_txs", oldLen, "new_num_txs", newBatchElementsLen) |
There was a problem hiding this comment.
It could be helpful to include the name in this logline so we know which batch submitter process its coming from, similar to line 143:
log.Info(name+" submitting batch tx", "start", start, "end", end,
"gasPrice", gasPrice)
|
Generally looks good to me, will approve if the itests all pass |
) ## Overview Introduces backpressure within the DA watcher channels. This change ensures that if the consumers of the DA watcher events (L1 {head/finalized} updates, unsafe block signer updates) do not process their events in a timely manner, the DA watcher doesn't endlessly fill up the channel queue, and yields until the other actors can process its pending updates. progress on #1993
…-rs/kona#2030) ## Overview Introduces backpressure within the DA watcher channels. This change ensures that if the consumers of the DA watcher events (L1 {head/finalized} updates, unsafe block signer updates) do not process their events in a timely manner, the DA watcher doesn't endlessly fill up the channel queue, and yields until the other actors can process its pending updates. progress on #1993
… and replaced with bounded ones (op-rs/kona#2045) Fixes #1993
4 participants
