integration-tests: Changes to make it work with live networks again by mslipper · Pull Request #2030 · ethereum-optimism/optimism

mslipper · 2022-01-19T15:45:38Z

No description provided.

changeset-bot · 2022-01-19T15:45:41Z

🦋 Changeset detected

Latest commit: 3710e8c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@eth-optimism/integration-tests	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov-commenter · 2022-01-19T15:56:09Z

Codecov Report

Merging #2030 (3710e8c) into develop (a3b11da) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #2030   +/-   ##
========================================
  Coverage    74.58%   74.58%           
========================================
  Files           79       79           
  Lines         2554     2554           
  Branches       401      401           
========================================
  Hits          1905     1905           
  Misses         649      649

Flag	Coverage Δ
batch-submitter	`62.50% <ø> (ø)`
contracts	`90.48% <ø> (ø)`
core-utils	`57.50% <ø> (ø)`
data-transport-layer	`38.64% <ø> (ø)`
message-relayer	`70.86% <ø> (ø)`
sdk	`88.38% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3b11da...3710e8c. Read the comment docs.

tynes · 2022-01-20T00:28:16Z

integration-tests/test/setup-docker-compose-network.ts

Why did you delete this files? To be honest, I never used them but I'm not sure if other people did. I always run docker compose manually

I don't think that these should be part of the repo. It introduces a hard coupling between the tests we define here, and the environment that they run on. It also causes the CLI to do a bunch of unexpected stuff unless an env var is set.

tynes · 2022-01-20T00:29:07Z

integration-tests/test/shared/env.ts

Confirmed there is a default value

tynes · 2022-01-20T00:29:54Z

integration-tests/test/shared/stress-test-helpers.ts

Gas estimation on L1 is failing? That is pretty strange to be honest

This just lets us specify a gas price manually if we want.

integration-tests/test/shared/utils.ts

tynes · 2022-01-20T00:32:13Z

integration-tests/test/shared/utils.ts

Same as above, this should be wei

integration-tests/test/replica.spec.ts

tynes · 2022-01-20T00:39:12Z

It looks like the L2 gasprice is being set to 0 in some places now based on the itest logs

Error: processing response error (body="{\"jsonrpc\":\"2.0\",\"id\":1114,\"error\":{\"code\":-32000,\"message\":\"cannot accept 0 gas price transaction\"}}\n", error={"code":-32000}, requestBody="{\"method\":\"eth_sendRawTransaction\",\"params\":[\"0xf868268082520894a8bd13ea2daadc1f0f1db036c67ac4d0fbc99cff872386f26fc100008082036ba081234402acea5122d30d7e955e3ee91466fbad724094de51f66b6e189b504b4aa02669e4b028fb671cd68fc0eec26909d28f511ee52f2acadc7aa4d8a395730657\"],\"id\":1114,\"jsonrpc\":\"2.0\"}", requestMethod="POST", url="http://l2geth:8545", code=SERVER_ERROR, version=web/5.4.0)

tynes · 2022-01-20T00:39:50Z

Could you add a changeset as well?

tynes · 2022-01-20T00:50:59Z

Also looks like some unused deps

Unused devDependencies
* @types/shelljs
* docker-compose
* shelljs

mslipper · 2022-01-20T03:31:21Z

This is still a bit of a WIP - working through some additional issues and needed it to run on CI.

tynes · 2022-01-22T00:16:25Z

integration-tests/test/fee-payment.spec.ts

      }

-      assertGasPrice()
+      await assertGasPrice()


Good catch here

) ## Overview Introduces backpressure within the DA watcher channels. This change ensures that if the consumers of the DA watcher events (L1 {head/finalized} updates, unsafe block signer updates) do not process their events in a timely manner, the DA watcher doesn't endlessly fill up the channel queue, and yields until the other actors can process its pending updates. progress on #1993

github-actions bot added the A-integration Area: integration tests label Jan 19, 2022

tynes reviewed Jan 20, 2022

View reviewed changes

integration-tests/test/shared/env.ts Outdated

Copy link

Contributor

tynes Jan 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed there is a default value

tynes reviewed Jan 20, 2022

View reviewed changes

integration-tests/test/shared/utils.ts Outdated Show resolved Hide resolved

tynes reviewed Jan 20, 2022

View reviewed changes

integration-tests/test/shared/utils.ts Outdated

Copy link

Contributor

tynes Jan 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above, this should be wei

tynes reviewed Jan 20, 2022

View reviewed changes

integration-tests/test/replica.spec.ts Outdated Show resolved Hide resolved

mslipper added the DO NOT MERGE label Jan 20, 2022

mslipper force-pushed the feat/nightly-itests branch 6 times, most recently from 2ca4a5b to 2f7bb9a Compare January 21, 2022 22:16

integration-tests: Changes to make it work with live networks again

c1e923f

mslipper force-pushed the feat/nightly-itests branch from 2f7bb9a to c1e923f Compare January 21, 2022 22:36

mslipper requested a review from tynes January 21, 2022 22:59

mslipper removed the DO NOT MERGE label Jan 21, 2022

tynes reviewed Jan 22, 2022

View reviewed changes

tynes approved these changes Jan 22, 2022

View reviewed changes

Merge branch 'develop' into feat/nightly-itests

3710e8c

mslipper merged commit f8531d8 into ethereum-optimism:develop Jan 22, 2022

Conversation

mslipper commented Jan 19, 2022

Uh oh!

changeset-bot bot commented Jan 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

codecov-commenter commented Jan 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

tynes Jan 20, 2022

Choose a reason for hiding this comment

Uh oh!

mslipper Jan 21, 2022

Choose a reason for hiding this comment

Uh oh!

tynes Jan 20, 2022

Choose a reason for hiding this comment

Uh oh!

tynes Jan 20, 2022

Choose a reason for hiding this comment

Uh oh!

mslipper Jan 21, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

tynes Jan 20, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

tynes commented Jan 20, 2022

Uh oh!

tynes commented Jan 20, 2022

Uh oh!

tynes commented Jan 20, 2022

Uh oh!

mslipper commented Jan 20, 2022

Uh oh!

tynes Jan 22, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

changeset-bot bot commented Jan 19, 2022 •

edited

Loading

codecov-commenter commented Jan 19, 2022 •

edited

Loading