This repository was archived by the owner on Jan 16, 2026. It is now read-only.
feat(node/service): removed unbounded channels in kona-service actors and replaced with bounded ones#2045
Merged
clabby merged 2 commits intoop-rs:mainfrom Jun 9, 2025
Conversation
PoulavBhowmick03
requested review from
clabby,
dhyaniarun1993,
emhane,
itschaindev,
refcell,
sadiq1971 and
theochap
as code owners
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR replaces unbounded mpsc channels with bounded ones in several actor modules, ensuring that channel send operations now await their completion.
- Replace unbounded channels with their bounded counterparts and update send calls to be asynchronous.
- Update tests and supporting actor logic to align with the new bounded channel semantics.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| crates/supervisor/service/src/actors/l1_watcher_rpc.rs | Updated channel type and replaced synchronous send with asynchronous send awaiting the result. |
| crates/node/service/src/service/validator.rs | Replaced unbounded channels with bounded channels for consistency. |
| crates/node/service/src/actors/runtime.rs | Changed channel type in runtime actor and updated send calls to be asynchronous. |
| crates/node/service/src/actors/network.rs | Updated channel types and adjusted send calls to use .await for async behavior. |
| crates/node/service/src/actors/engine/actor.rs | Updated channel types and ensured send calls await proper completion. |
| crates/node/service/src/actors/derivation.rs | Replaced unbounded channels with bounded ones and updated send operations accordingly. |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
clabby
reviewed
Jun 9, 2025
Contributor
clabby
left a comment
clabby
left a comment
There was a problem hiding this comment.
Looking good, thank you.
One nit along with Copilot's, then glad to approve :)
Contributor
Author
|
@clabby made the changes |
clabby
approved these changes
Jun 9, 2025
Contributor
clabby
left a comment
clabby
left a comment
There was a problem hiding this comment.
Looks good, pending CI. Thanks!
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Dec 10, 2025
… and replaced with bounded ones (op-rs/kona#2045) Fixes op-rs/kona#1993
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Jan 14, 2026
… and replaced with bounded ones (op-rs/kona#2045) Fixes #1993
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1993