Merged
Conversation
…315) - Perform the build in incremental steps, to reduce memory footprint of the build. - Additionally, separate test and build, to ensure they won't run concurrently. This helps stabilize the python integration test. These two things combined seem to help stabilize ASAN in CI. I could confirm a couple of consecutive succeeding CI runs: https://app.circleci.com/pipelines/github/envoyproxy/nighthawk?branch=pull%2F315 Associated issue: #272 Leaving that open for now, let's close it later if we're confident the problem is resolved. Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Update to the latest + fixes to unbreak the build Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
- Trace id generation broke. This was amended by directly using the new request id uid implementation. It would be nice to leverage the new request id extension capability later for this. - Amended calls to get counters by name - Synced .bazelrc - Histogram value formatting subtly changed in some cases, probably caused by an update to Envoy's dependency on `libfmt`. Introduce an explicit formatting specifier in the affected output formatting code to address that. - Tweaks for resolving new OOM issues with ASAN/TSAN in CI that started with the updated Envoy revision. This affected both the build process as well as the testing process itself. Notably, the python-based integration tests would get OOM-killed in asan runs. Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Make unit tests to use advanceTimeWait in favor of sleep (see envoyproxy/envoy#10551) Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Adi Suissa-Peleg <adip@google.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Related to #317 Log any exceptions and rethrow. This is to assist with diagnosis once it happens again in the CI env. Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
We don't reliably cover HttpTestServerDecoderFilter::sendReply() with bad request-header configuration. Add a c++ unit test to reliably cover that. Fixes #296 Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Fixes #268 Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
This Envoy update is a bit more involved, because it forced moving away from the legacy connection pools it had, which got eliminated from the code base. So we migrate to Envoy's new pool models. * The h1 pool migrates seamlessly to the new model with minor changes. * The experimental h2 connection pool that supports multiple connections gets dropped. We now offer multiple connection support based on the new H2 pool. Behavior has changed, but there was a warning about that in the description of the --experimental flag (see changes to the test associated to our earlier experimental h2 pool) It should now be possible to add new options to add better support for h2 & multiple connections, and deprecate or remove the --experimental flag for that. Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
- As of this change we needed to reduce parallelism in CI to avoid OOM during coverage runs. This probably can be traced back to a new way of running coverage being used in Envoy, which trickled down to Nighthawk. - Removed our own `io_bazel_rules_python` as we can now piggy-back on Envoy for that. - Removes a file that accidentally crept in (lorem_ipsum.txt) Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.