Skip to content

CircleCI: reduce ASAN parallelism#324

Merged
mum4k merged 1 commit intoenvoyproxy:masterfrom
oschaaf:ci-asan-num-cpus
Apr 20, 2020
Merged

CircleCI: reduce ASAN parallelism#324
mum4k merged 1 commit intoenvoyproxy:masterfrom
oschaaf:ci-asan-num-cpus

Conversation

@oschaaf
Copy link
Copy Markdown
Member

@oschaaf oschaaf commented Apr 17, 2020

Another stab at #272
Since the last Envoy update the ASAN build runs out of memory more often then not.

I noticed that the earlier attempt at reducing NUM_CPUS/--jobs didn't yield expected
results in CI, as bazel would still be running 8 jobs in parallel.

Upon investigation, I noticed that my earlier attempt had issues:

  • it set the wrong variable
  • upon fixing that, the script would end up handing two --jobs=x arguments to bazel

The approach here sets NUM_CPUS early on in the script, and doesn't attempt to mess
with the build flags later on.

Hopefully fixes #272

Signed-off-by: Otto van der Schaaf oschaaf@we-amp.com

Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
@oschaaf
Copy link
Copy Markdown
Member Author

oschaaf commented Apr 18, 2020

Yeah, checking the CI build logs, bazel seems to run the expected amount of parallel actions (5) for ASAN. Marking this is ready for review.

@oschaaf oschaaf added waiting-for-review A PR waiting for a review. P1 labels Apr 18, 2020
@mum4k mum4k merged commit 79f5873 into envoyproxy:master Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P1 waiting-for-review A PR waiting for a review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI flaking on asan runs

2 participants