CircleCI: reduce ASAN parallelism#324
Merged
mum4k merged 1 commit intoenvoyproxy:masterfrom Apr 20, 2020
Merged
Conversation
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
Member
Author
|
Yeah, checking the CI build logs, bazel seems to run the expected amount of parallel actions (5) for ASAN. Marking this is ready for review. |
mum4k
approved these changes
Apr 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another stab at #272
Since the last Envoy update the ASAN build runs out of memory more often then not.
I noticed that the earlier attempt at reducing
NUM_CPUS/--jobsdidn't yield expectedresults in CI, as bazel would still be running 8 jobs in parallel.
Upon investigation, I noticed that my earlier attempt had issues:
--jobs=xarguments to bazelThe approach here sets
NUM_CPUSearly on in the script, and doesn't attempt to messwith the build flags later on.
Hopefully fixes #272
Signed-off-by: Otto van der Schaaf oschaaf@we-amp.com