Supplement doc comments in interface headers.#330
Merged
mum4k merged 2 commits intoenvoyproxy:masterfrom Apr 28, 2020
Merged
Conversation
Fixes envoyproxy#268 Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
mum4k
requested changes
Apr 27, 2020
include/nighthawk/client/factories.h
Outdated
| * @param dispatcher supplies the owning thread's dispatcher. | ||
| * @param scope stats scope for any stats tracked by the benchmark client. | ||
| * @param cluster_manager Cluster manager preconfigured with our target cluster. | ||
| * @param http_tracer http tracer |
Collaborator
There was a problem hiding this comment.
(nit) Do we have anything more interesting to say about this, maybe what it is used for pr what it means in the context of this function? The current comment is kind of redundant.
Member
Author
There was a problem hiding this comment.
yeah, that wasn't a very helpful doc comment :-)
done in 28487f0
mum4k
added
waiting-for-changes
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
oschaaf
added
waiting-for-review
mum4k
approved these changes
Apr 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #268
Signed-off-by: Otto van der Schaaf oschaaf@we-amp.com