Coverage: HttpTestServerDecoderFilter::sendReply()#329
Merged
mum4k merged 1 commit intoenvoyproxy:masterfrom Apr 27, 2020
Merged
Coverage: HttpTestServerDecoderFilter::sendReply()#329mum4k merged 1 commit intoenvoyproxy:masterfrom
mum4k merged 1 commit intoenvoyproxy:masterfrom
Conversation
We don't reliably cover HttpTestServerDecoderFilter::sendReply() with bad request-header configuration. Add a c++ unit test to reliably cover that. Fixes envoyproxy#296 Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
mum4k
approved these changes
Apr 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't reliably cover all flows in
HttpTestServerDecoderFilter::sendReply().Add a c++ unit test to address that and stop this particular source of CI coverage
flakes.
Fixes #296
Signed-off-by: Otto van der Schaaf oschaaf@we-amp.com