Skip to content

Update Envoy to 3a2512d923e2eee1fce9f4f6a23cf93f2e7ed93f#316

Merged
mum4k merged 3 commits intoenvoyproxy:masterfrom
oschaaf:update-envoy-dep-14
Mar 11, 2020
Merged

Update Envoy to 3a2512d923e2eee1fce9f4f6a23cf93f2e7ed93f#316
mum4k merged 3 commits intoenvoyproxy:masterfrom
oschaaf:update-envoy-dep-14

Conversation

@oschaaf
Copy link
Copy Markdown
Member

@oschaaf oschaaf commented Mar 10, 2020

Update to the latest + fixes to unbreak the build

Signed-off-by: Otto van der Schaaf oschaaf@we-amp.com

@oschaaf
Update Envoy to 3a2512d923e2eee1fce9f4f6a23cf93f2e7ed93f
4aae17a 
Update to the latest + fixes to unbreak the build

Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
@oschaaf oschaaf added P0 Highest priority waiting-for-review A PR waiting for a review. labels Mar 10, 2020
oschaaf added 2 commits March 10, 2020 13:45
@oschaaf
Amend newly found formatting issues by check_format
3310a58 
The Envoy update includes a new formatting rules, which
caught some bad test names with respect to casing.
Fix those.

Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
@oschaaf
Merge remote-tracking branch 'upstream/master' into update-envoy-dep-14
207d2d7 
Signed-off-by: Otto van der Schaaf <oschaaf@we-amp.com>
@oschaaf oschaaf removed the waiting-for-review A PR waiting for a review. label Mar 10, 2020
@oschaaf
Copy link
Copy Markdown
Member Author

oschaaf commented Mar 10, 2020

Checking the TSAN failure logs, it looks like a real issue was caught.

[ RUN      ] ClientTest.AutoConcurrencyRun
[14:11:50.442223][31224][C] [source/client/process_impl.cc:124] assert failure: shutdown_. Details: shutdown not called before destruction.
[14:11:50.448097][31224][C] [bazel-out/k8-dbg/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:83] Caught Aborted, suspect faulting address 0x79f8
[14:11:50.448206][31224][C] [bazel-out/k8-dbg/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:70] Backtrace (use tools/stack_decode.py to get line numbers):
[14:11:50.449640][31224][C] [bazel-out/k8-dbg/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:71] Envoy version: 0/1.14.0-dev/redacted/DEBUG/BoringSSL
[14:11:50.670944][31224][C] [bazel-out/k8-dbg/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:75] #0: Envoy::SignalAction::sigHandler() [0x683abe7]
[14:11:50.866130][31224][C] [bazel-out/k8-dbg/bin/external/envoy/source/server/_virtual_includes/backtrace_lib/server/backtrace.h:75] #1: __tsan::CallUserSignalHandler() [0x2789350]
external/bazel_tools/tools/test/test-setup.sh: line 310: 31224 Aborted                 "${TEST_PATH}" "$@" 2>&1
================================================================================

@oschaaf oschaaf mentioned this pull request Mar 10, 2020
Open
@oschaaf
Copy link
Copy Markdown
Member Author

oschaaf commented Mar 10, 2020

Deferred the TSAN failure to #317.

@oschaaf oschaaf added the waiting-for-review A PR waiting for a review. label Mar 10, 2020
@mum4k mum4k merged commit 5652d35 into envoyproxy:master Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mum4k mum4k mum4k approved these changes

Assignees

No one assigned

Labels

P0 Highest priority waiting-for-review A PR waiting for a review.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@oschaaf @mum4k