changelog: Add docs/examples changes + cleanups#22204
Conversation
|
Docs for this Pull Request will be rendered here: https://storage.googleapis.com/envoy-pr/22204/docs/index.html The docs are (re-)rendered each time the CI |
|
i will add some cleanups to this PR before i unWIP it, but we kinda need to land above PRs for it to be correct |
85a7ba2 to
b8ae309
Compare
14a6799 to
0b67eb3
Compare
|
@adisuissa i have tried to make the literals as consistent as possible just this file throws up an interesting mix - names, acronyms and literals, where the distinction is not always clear cut another example is numbers - i generally think dont literalize numbers - they would be localized in most cases - but eg response codes are a grey area - also numbers with a math operator maybe should be literals - but not sure about either way i think this makes it a bit more consistent |
99bd094 to
2f8928c
Compare
|
arggh - i just noticed that its not ordering alphabetically - ill try and fix now |
2f8928c to
82a2480
Compare
82a2480 to
c7bad1a
Compare
|
/wait for #22205 |
c7bad1a to
f9699aa
Compare
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
04677ce to
8123062
Compare
|
i need fo check this over for dupes - the way the git merge works on this file can create them |
8123062 to
9737616
Compare
9737616 to
f0befcd
Compare
f0befcd to
bb16f54
Compare
|
@adisuissa i think this one should be ready for final review - im reasonably confident im not undoing any of the changes you just made, and ive rinsed out the dupes |
adisuissa
left a comment
There was a problem hiding this comment.
Thanks.
Also in line 313 there "true" -> "true"
|
argg DCO |
|
im gonna have to rebase/force to fix DCO - sorry - damn github! |
Partial fix for envoyproxy#22065 Signed-off-by: Ryan Northey <ryan@synca.io>
93843fd to
8c45913
Compare
Partial fix for #22065
includes cleanups:
Signed-off-by: Ryan Northey ryan@synca.io
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]