examples: Version updates and cleanups#22092
Merged
phlax merged 3 commits intoenvoyproxy:mainfrom Jul 14, 2022
Merged
Conversation
phlax
changed the title
phlax
force-pushed
the
examples-skywalking
branch
from
1b97e4b to
65b2ff0
Compare
phlax
force-pushed
the
examples-skywalking
branch
from
65b2ff0 to
74caceb
Compare
phlax
changed the title
Member
Author
|
@adisuissa this one would be good to land im trying to clean up the examples before release - with the hope of reducing flakes on the release branch |
Bumps golang from 1.13.0-stretch to 1.18.3-stretch. --- updated-dependencies: - dependency-name: golang dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Ryan Northey <ryan@synca.io>
Bumps elasticsearch from 7.9.2 to 8.3.2. --- updated-dependencies: - dependency-name: elasticsearch dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Ryan Northey <ryan@synca.io>
- Bump skywalking and resolve version issues - Bump container/go versions for grpc - Bump container version for zstd - Run all verify jobs together (as disk space is less of an issue) - Use shared/echo container for lua - Use shared/echo container for wasm Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
force-pushed
the
examples-skywalking
branch
from
74caceb to
78af43b
Compare
adisuissa
reviewed
Jul 14, 2022
| exit 0 | ||
| elif [[ "$CI_TARGET" == "verify_examples" ]]; then | ||
| run_ci_verify "*" "wasm-cc|win32-front-proxy|shared" | ||
| run_ci_verify "*" "win32-front-proxy|shared" |
Contributor
There was a problem hiding this comment.
I may be missing some context, why is wasm-cc not being validated anymore?
it's still part of the examples, so should be validated, no?
Member
Author
There was a problem hiding this comment.
in this line its not being excluded
it is being validated now in this test - just not separately
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]