Skip to content

docs: updating changelog pre release - part2#22205

Merged
phlax merged 5 commits intoenvoyproxy:mainfrom
adisuissa:fix_changelog_1.23_part2
Jul 15, 2022
Merged

docs: updating changelog pre release - part2#22205
phlax merged 5 commits intoenvoyproxy:mainfrom
adisuissa:fix_changelog_1.23_part2

Conversation

@adisuissa
Copy link
Copy Markdown
Contributor

Commit Message: updating changelog pre release - part2
Additional Description: Followup of #22194
Risk Level: N/A
Testing: N/A
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A

Signed-off-by: Adi Suissa-Peleg adip@google.com

Signed-off-by: Adi Suissa-Peleg <adip@google.com>
@repokitteh-read-only
Copy link
Copy Markdown

Docs for this Pull Request will be rendered here:

https://storage.googleapis.com/envoy-pr/22205/docs/index.html

The docs are (re-)rendered each time the CI envoy-presubmit (precheck docs) job completes.

🐱

Caused by: #22205 was opened by adisuissa.

see: more, trace.

@adisuissa
Copy link
Copy Markdown
Contributor Author

cc @alyssawilk please LMK if you see anything strange in the latest changelog

Copy link
Copy Markdown
Contributor

@alyssawilk alyssawilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it'd be nice to have consistent capitalization. We have a of
foo: did bar
and
eep: Did baz

phrasing for HTTP/3 early data is a bit unusual: requires A and B to be turned on. It's unclear they both are by default,

re-configuration -> reconfiguration

lua timeStampToString - can have docs link?

error: dubbo proxy: added metadara_path on the same line as prior router feature?

rfc1808 should have link, fixed parens

thrift changes should have links :-/ We should ping reviewer there to make sure they're done inline next time

not sure clang 14 is a new feature?

Comment thread changelogs/current.yaml
- area: runtime
change: |
removed ``envoy.restart_features.no_runtime_singleton`` and replaced with ``envoy.restart_features.remove_runtime_singleton``.
- area: udp listener
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added support for command operators in :ref:`TunnelingConfig hostname

doesn't seem like a backwards incompatible change

Signed-off-by: Adi Suissa-Peleg <adip@google.com>
Comment thread changelogs/current.yaml
change: |
added :ref:`internal upstream transport <envoy_v3_api_msg_extensions.transport_sockets.internal_upstream.v3.InternalUpstreamTransport>` for passing metadata and filter state across the user space sockets and the internal listeners.
- area: router
change:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @phlax we should ideally catch this one in CI

alyssawilk
alyssawilk previously approved these changes Jul 14, 2022
Copy link
Copy Markdown
Contributor

@alyssawilk alyssawilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for all the clean up!

…part2

Signed-off-by: Adi Suissa-Peleg <adip@google.com>
Signed-off-by: Adi Suissa-Peleg <adip@google.com>
Signed-off-by: Adi Suissa-Peleg <adip@google.com>
@adisuissa
Copy link
Copy Markdown
Contributor Author

@phlax PTAL

@adisuissa
Copy link
Copy Markdown
Contributor Author

/retest

@repokitteh-read-only
Copy link
Copy Markdown

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #22205 (comment) was created by @adisuissa.

see: more, trace.

@phlax phlax added this to the 1.23.0 milestone Jul 15, 2022
Copy link
Copy Markdown
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adisuissa apologies i thought this had landed already

lgtm, not sure if you want to address @alyssawilk 's feedback further

@adisuissa
Copy link
Copy Markdown
Contributor Author

@adisuissa apologies i thought this had landed already

lgtm, not sure if you want to address @alyssawilk 's feedback further

All comments should be addressed.
Once this lands, and the rest of the milestone issues are done, we can start with the release process.

@phlax
Copy link
Copy Markdown
Member

phlax commented Jul 15, 2022

i would like half an hour or so with the final branch to run some local testing - but i can do it as we go along (#22199 )

@phlax phlax merged commit 430a2ce into envoyproxy:main Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants