examples: Improve waits/fix flakes#22126
Merged
KBaichoo merged 3 commits intoenvoyproxy:mainfrom Jul 14, 2022
Merged
Conversation
phlax
commented
Jul 12, 2022
Fix envoyproxy#22113 Signed-off-by: Ryan Northey <ryan@synca.io>
KBaichoo
reviewed
Jul 14, 2022
| wait_for 30 bash -c "\ | ||
| responds_with \ | ||
| '<!doctype html>' \ | ||
| http://localhost:${PORT_ADMIN}/zipkin/" |
Contributor
There was a problem hiding this comment.
Might be missing context, why are we querying it twice with same query? Here and a few other places
Member
Author
There was a problem hiding this comment.
the most reliable way of checking that the test is ready to be run is just waiting for the test to pass
ditto elsewhere
despite trying i didnt find a way to make this wait for docker correctly - i guess i could just move these to healthchecks on the compositions
my pref is to land and iterate because these make ci less flakey and faster
Signed-off-by: Ryan Northey <ryan@synca.io>
KBaichoo
approved these changes
Jul 14, 2022
| wait_for 30 bash -c "\ | ||
| responds_with \ | ||
| '<!doctype html>' \ | ||
| http://localhost:${PORT_ADMIN}/zipkin/" |
Signed-off-by: Ryan Northey <ryan@synca.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #22113
Signed-off-by: Ryan Northey ryan@synca.io
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]