Skip to content

docs: Fix example composition build instructions#22132

Merged
phlax merged 1 commit intoenvoyproxy:mainfrom
phlax:docs-examples-build
Jul 14, 2022
Merged

docs: Fix example composition build instructions#22132
phlax merged 1 commit intoenvoyproxy:mainfrom
phlax:docs-examples-build

Conversation

@phlax
Copy link
Copy Markdown
Member

@phlax phlax commented Jul 12, 2022

Follow on fix for #20915

Signed-off-by: Ryan Northey ryan@synca.io

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

Follow on fix for envoyproxy#20915

Signed-off-by: Ryan Northey <ryan@synca.io>
@repokitteh-read-only
Copy link
Copy Markdown

Docs for this Pull Request will be rendered here:

https://storage.googleapis.com/envoy-pr/22132/docs/index.html

The docs are (re-)rendered each time the CI envoy-presubmit (precheck docs) job completes.

🐱

Caused by: #22132 was opened by phlax.

see: more, trace.

@phlax
Copy link
Copy Markdown
Member Author

phlax commented Jul 12, 2022

/retest

@repokitteh-read-only
Copy link
Copy Markdown

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #22132 (comment) was created by @phlax.

see: more, trace.

@phlax phlax changed the title docs: Fix example build instructions docs: Fix example composition build instructions Jul 12, 2022
Copy link
Copy Markdown
Contributor

@adisuissa adisuissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@phlax phlax merged commit 181bd2a into envoyproxy:main Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants